PHP "while" loop is not executing second command for each loop

Question

I have a text file with three words in it; each on a separate row: child, toy, people. I am using the Laravel Str::plural() function to pluralize each word and display the results with line breaks.

It works perfectly when I use the words in my code without a file, as so:

        $output1 = Str::plural('child');
        $output2 = Str::plural('toy');
        $output3 = Str::plural('person');

        $string = $output1 . "\r\n" . $output2 . "\r\n" . $output3;
        echo nl2br($string);

The result shows as follows:

children
toys
people

However, when I use a "while" loop through a file containing these words, it only pluralizes the last word.

This is the "while" loop code:

$myFile = new \SplFileObject("words.txt");

while (!$myFile->eof()) {

     $string = Str::plural($myFile->fgets());
     echo nl2br($string);
}

As you can see from the result, only the last word is pluralized:

child
toy
people

Since my loop has brackets {} I assumed that BOTH lines of codes execute for each loop but I guess in PHP it's not like that? Any idea how to fix my "while" loop?

Your loop is probably only executing once, and you are passing the entire string into the function, not individual words. It is possible this is a line-ending problem. — Chris Haas
– Chris Haas, Commented Oct 26, 2021 at 13:46
It works for me locally, so I agree that it's a line-ending problem. Try $str = trim($myFile->fgets()); $string = Str::plural($str); — aynber
– aynber, Commented Oct 26, 2021 at 13:48
@aynber works great, just the "trim" is putting all the words into one word (no spaces: childrentoyspeople) and my nl2br is not working (maybe it would work if there were spaces in between the words.) Since I'm new to PHP, I'll just research the trim function - but now it works! Thanks. You can put this as an answer (and maybe add the trim fix too) — Zvi Twersky
– Zvi Twersky, Commented Oct 26, 2021 at 13:55
@ChrisHaas I see that article is talking about a MAC. I'm on a PC. — Zvi Twersky
– Zvi Twersky, Commented Oct 26, 2021 at 13:58

aynber · Accepted Answer · 2021-10-26 13:58:58Z

1

There may be some extra spaces or line-ending characters, so you'll need to trim the string before you pluralize it.

$str = trim($myFile->fgets()); // Remove white space from the word/line
$string = Str::plural($str);

However, the nl2br will not work since there are no longer any new lines, so you'll want to append the br to the words.

echo "$string<br>";

answered Oct 26, 2021 at 13:58

aynber

23.2k9 gold badges57 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Roman Krut · Accepted Answer · 2021-10-26 20:20:55Z

0

I think you have written words in file on separate rows; It means that of the end of each row you have hidden symbols \r\n I can say it because "person" is pluralized correclty and there is no other words after that in your example. You can easy check it with debug or var_dump function;

echo var_dump($yourString);

You will see something like this

string(5) "toy
"

answered Oct 26, 2021 at 20:20

Roman Krut

1768 bronze badges

Collectives™ on Stack Overflow

PHP "while" loop is not executing second command for each loop

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related