Setting Cells' Text From An Array

Question

I think I'm missing something very simple here. The cell's text is being set to the same thing for each cell right now. Can anyone see my error?

for (ProductItem *code in codeAray1)
        {
            NSString *codeText = code.code;
            NSString *nameText = code.name;
            NSString *cellText = [NSString stringWithFormat:@"%@: %@", codeText, nameText];
            cell.textLabel.text = cellText;
        }

And this is how the array is created from SQLite query:

        ProductItem *code = [[HCPCSCodes alloc] init];
        code.code = [NSString stringWithCString:(char *)sqlite3_column_text(statement, 0) encoding:NSUTF8StringEncoding];
        code.name = [NSString stringWithCString:(char *)sqlite3_column_text(statement, 1) encoding:NSUTF8StringEncoding];
        code.description = [NSString stringWithCString:(char *)sqlite3_column_text(statement, 2) encoding:NSUTF8StringEncoding];
        [codeAray1 addObject:code];
        [code release];
    }

Vladimir · Accepted Answer · 2011-08-07 20:12:30Z

1

You set text to the same cell on each loop iteration in your 1st snippet (wherever that code is)... You need to set text based on the current row of a cell

Basically, that code should be in cellForRowAtIndexPath: method in table's data source and look like:

- (UITableViewCell*) tableView:(UITableView*)tableView cellForRowAtIndexPath:(NSIndexPath)*indexPath{
    UITableViewCell *cell = ...// create/deque/setup cell

    // Now get just the code that should be displayed in a given row
    ProductItem *code = [codeAray1 objectAtIndex: indexPath.row];
    NSString *codeText = code.code;
    NSString *nameText = code.name;
    NSString *cellText = [NSString stringWithFormat:@"%@: %@", codeText, nameText];
    cell.textLabel.text = cellText;

    return cell;
}

answered Aug 7, 2011 at 20:12

Vladimir

171k36 gold badges392 silver badges313 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Jon Over a year ago

Yes, I think you're right, so something like [codeArray1 objectAtIndex:indexPath.row], but where exactly?

Jon Over a year ago

But isn't it better to do something similar to what I have, because I heard that with so many cells (around 5000), it is easy for it to go out of bonds this way.

Vladimir Over a year ago

@Jon, no. UITableView caches its cells when they go out of the visible area and reuses them when possible for different rows. So in practice it does not matter how many rows table has, the number of cell objects created will be "number of visible rows" + 2 or so

Vladimir Over a year ago

That way we won't need to create 5000 cells which would have been too expensive

Jon Over a year ago

Thanks, do you know, based on how I setup the array, how to sort by code property?

|

Collectives™ on Stack Overflow

Setting Cells' Text From An Array

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related