Batch file only run once, FOR loop at fault

Question

I'm looking for a batch that look into folders that begins with "@" and then inside those folders have a subfolder named "Keys" copy a file.bikey to a static folder name "keys".

The for /d loop that I use apparently stops working due to a cd/goto commands inside.

Main
│   key-collector.bat
│
├───@folder_a
│   └───keys
│           a.txt
│
├───@folder_b
│   └───keys
│           b.txt
│
├───@folder_c
│   └───keys
│           c.txt
└───keys
    └───(Destination)

Current code:

@echo off
:start
set modsPath="C:\Exemple"
set keysPath="%modsPath%\keys"
for /d %%i in (@*) do (
    echo %%i
    copy /y %cd%\%%i\keys\*.txt %keysPath%
    ::cd %cd%\%%i\keys
    ::copy *.txt %keysPath%
    )
PAUSE>nul
exit

do not use an invalid label inside a code block. change :: to rem. Then on the cd command, why even cd? just copy the files from full path or pushd path and popd after the copy. — user7818749
– user7818749, Commented Oct 29, 2021 at 14:18

user7818749 · Accepted Answer · 2021-10-29 14:39:17Z

1

Few things:

set the path with double quotes including the variable name i.e set "var=value"
Do not use invalid labels :: inside a code block, instead use rem
add double quotes to your paths for instance: copy /y "%cd%\%%i\keys\*.txt" "%keysPath%"
use %%~fi for the full path instead of cd

@echo off
:start
set "modsPath=C:\Example"
set "keysPath=%modsPath%\keys"
for /d %%i in (@*) do (
    echo %%~fi
    copy /y "%%~fi\keys\*.txt" "%keysPath%"
    rem comments like this
    )
pause>nul

answered Oct 29, 2021 at 14:39

user7818749

Sign up to request clarification or add additional context in comments.

3 Comments

T92E Over a year ago

It doesn't seems to understand the %%~fi, it returns: %~fi (from echo) and "Path not found"

user7818749 Over a year ago

Did you copy the code as is? please double check. %%~f is a valid expansion for a variable. see for /? from cmd

T92E Over a year ago

I mixed up my actual batch with my copy for testing, it works well, I really do appreciate your help. thank you

Collectives™ on Stack Overflow

Batch file only run once, FOR loop at fault

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related