Ruby: working with arrays

Question

I am working on a script that collects all comments from my DB and inserts them into a hash. I then do a collect on the comments hash and split the comments into two separate comment hashes (vid_comments & wall_comments)

w_hash["comments"] << contender.profile.comments.where("created_at > DATE_SUB( NOW(), INTERVAL 1 DAY)")
    w_hash["comments"].delete_if { |x| x.blank? }
    w_hash["vid_comments"], w_hash["wall_comments"] = [], []

    w_hash["comments"].each do |c|
      if !c.media_id.nil?
        w_hash["vid_comments"] << c
      elsif c.parent_id == 0
        w_hash["wall_comments"] << c
      end
    end

Is there anyway to shorten the code? I am pretty new to Ruby (PHP import) so excuse my ignorance in things I may be doing wrong.

EDIT: Added in code bit from @Mchl (below)..

Consider moving your question to codereview.stackexchange.com. — maerics
– maerics, Commented Aug 9, 2011 at 15:22
Thanks! Post moved to codereview: codereview.stackexchange.com/questions/3987/… — dennismonsewicz
– dennismonsewicz, Commented Aug 9, 2011 at 15:26

Mchl · Accepted Answer · 2011-08-09 15:28:49Z

1

One way I see (being a recent PHP import myself) would be to change this:

w_hash["vid_comments"] = w_hash["comments"].collect { |c| !c.media_id.nil? }
w_hash["wall_comments"] = w_hash["comments"].collect { |w| w.parent_id == 0 }

Into

w_hash["comments"].each do |c|
  if !c.media_id.nil?
    w_hash["vid_comments"] << c
  elsif c.parent_id == 0
    w_hash["wall_comments"] << c
  end
end

answered Aug 9, 2011 at 15:28

Mchl

62.4k9 gold badges121 silver badges121 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

dennismonsewicz Over a year ago

Thanks!! I have recently been introduced to the .collect method in Ruby and have been trying to get better at DRY(ing) up my code! Thanks for the help!

Mchl Over a year ago

There's probably a way to do it all in one simple and elegant line, but I'm not there yet ;P

dennismonsewicz Over a year ago

Me either :P I ended up modifying your code slightly... I pasted the new above

Collectives™ on Stack Overflow

Ruby: working with arrays

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related