Wondering if anyone can help - I'm sure this was working before, but I can't get a mysql update to work
$db->query("UPDATE entry_pending_details SET old_value = '{$value ["old_value"]}' WHERE id = '{$value ["id"]}'");
it's clearly the variables not being recognised as if I drop hardcoded values in it's ok.
Any ideas ?
Thanks
Your problems are probably:
You have double quotes within a double quoted string. This shouldn't even run, it's a syntax error.
The space between the variable names and the brackets.
You're potentially vulnerable to SQL injection attacks, and definitely vulnerable to your own logic errors.
Use bound parameters instead.
$st = $db->prepare("UPDATE entry_pending_details SET old_value = ? WHERE id = ?");
$st->execute(array($value['old_value'], $value['id']));
{} notation works just fine with spaces. e.g. echo {$x ['a']} and echo {$x['a']} both work just fine with $x['a'] = 'yo' and give me 'yo' as (un)expected.You have to use single quotes ' or escape double ones around array indices (like \"). I replaced double quotes with single ones
"UPDATE entry_pending_details SET old_value = '{$value['old_value']}' WHERE id = '{$value['id']}'"
" within a {} array var do not "break" the string on 5.3.2.
$value ["id"] and use some mySQL admin software to check does the record with that id exists in DB (ie perhaps the update fails as there is no record to update).what I would do is set the values as vars beforehand. e.g
$old_value = $value['old_value'];
$id = $value['id'];
mysql_query("UPDATE entry_pending_details SET old_value = '$old_value' WHERE id = '$id'");
Try the following:
$sql = "UPDATE entry_pending_details SET old_value = '{$value ["old_value"]}' WHERE id = '{$value ["id"]}'";
mysql_query($sql) or die(mysql_error());
echo $sql;
It's a good idea to put the query into a variable so you can examine it later if need be.
As well, what does var_dump($values) show?
