PHP add many rows to database

Question

I have problem with database. I want to add about 10 new rows after pageload. It should check if there is an article with id (that is actually loading). If its not, add 10 of that id with different tag id.

$sprawdz = "SELECT id_artykulow FROM tag_art WHERE id_artykulow='".$_GET['id']."' " ;
$miasto = mysql_query($sprawdz);   
$a = mysql_num_rows($miasto); 
while ($a<=10){ 
$zm = "SELECT id FROM tag_content ORDER BY RAND() LIMIT 1";
$sw = mysql_query($zm);
while($row3=mysql_fetch_array($sw)){
$zmienna = "INSERT INTO tag_art(id_artykulow, id_tagow) VALUES ('".$_GET['id']."', '".$row3['id']."' ) ";
$cokolwiek = mysql_query($zmienna);
}
$a++; 
}

There is two tables. One tag_content with id (of the tags), and another tag_art with id_artykulow (= id of the article) and id_tagow (id of the tag taken from tag_content) Don't know why, but it doesn't add 10 rows (it should be for example ten id_artykulow = 10, with different id_tagow). How to fix it?

Thx for help and let me know if u need more informations (like more code etc.)

Dwie tabele. Jedna (tag_art) trzyma id_artykulow i id_tagow, druga (tag_content) samo id (konkretnych tagow). Każdy artykuł ma własny id. Po załadowaniu strony php sprawdza (a raczej powinien), czy artykuł o podanym id ma już przypisane tagi. Jeżeli nie, to powinien dodać 10 razy do tabeli tag_art id tego artykułu (do id_artykulow) wraz z randomowymi id_tagow (pobranych z tag_content). — Amay
– Amay, Commented Aug 10, 2011 at 8:01
So basically: You want to 1. check whether an article has any tags. 2 If not, select 10 tags at random and attach them to the article. — cbednarski
– cbednarski, Commented Aug 10, 2011 at 8:09
Dawid: bo nie dodaje 10 nowych wierszy. I właśnie nie mam pojęcia dlaczego. — Amay
– Amay, Commented Aug 10, 2011 at 9:36

Puggan Se · Accepted Answer · 2011-08-10 08:13:44Z

2

why do you have 2 while loops? cant you just replace

while ($a<=10){ 
$zm = "SELECT id FROM tag_content ORDER BY RAND() LIMIT 1";

with

if ($a<=10){ 
$zm = "SELECT id FROM tag_content ORDER BY RAND() LIMIT " . (10-$a);

or just let the databse do all the work by:

$query = "INSERT INTO tag_art(id_artykulow, id_tagow) SELECT '".$_GET['id']."', id  FROM tag_content ORDER BY RAND() LIMIT " . (10-$a);

(and i would also recomendate protection agains sql-injections, mysql_real_escape_string())

answered Aug 10, 2011 at 8:13

Puggan Se

5,8462 gold badges25 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Puggan Se · Accepted Answer · 2013-05-31 18:07:32Z

Or let the database do all the work:

// store id as mysql-variable, but let php force it to an integer first
mysql_query("SET @id = " . (int) $_GET['id']);

// calculate how many new art we need, to get 10, using greatest to avoid negative numbers
mysql_query("SELECT @art_needed := GREATEST(0, 10 - COUNT(*)) FROM tag_art WHERE id_artykulow = @id");

// Need to use prepere to be able to have an mysql-variable as limit
mysql_query("PREPARE art_stmt FROM 'INSERT INTO tag_art(id_artykulow, id_tagow) SELECT ?, id FROM tag_content ORDER BY RAND() LIMIT ?'");

// execute the query using the mysql-variables
mysql_query("EXECUTE art_stmt USING @id, @art_needed");

just reread my old answer, and no longer agrees with "or just let the databse do all the work by" for that answer, the database could do alot more.

Collectives™ on Stack Overflow

PHP add many rows to database

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related