Can I edit multiple array values in one line in C#

Question

So I have some very basic code, and I want to know if it would be better to put it in an array, and if it is possible to edit multiple values of an array in a single line.

My code looks like this, and as you could guess there is a btn_****_Click method for each of those bools. I could obviously do a bool[] whichClick = new bool and then add them all, but is there a shorthand way to edit all 7 bools in a single command? Doesn't do me any good to put it in an array if I'm still stuck using 7 lines to set all 7 bools, in each of the methods.

private void btn_Byte_Click(object sender, EventArgs e)
    {
        byteClick = true;
        shortClick = false;
        intClick = false;
        longClick = false;
        floatClick = false;
        douClick = false;
        decClick = false;
    }
   public void PostProcess(decimal left, decimal right, decimal answer, string oP)
    {
        string outputStr = "";

        // If statements for which data type was selected
        if (byteClick == true)
        {
            try
            {
                byte byteLeft = Decimal.ToByte(left);
                byte byteRight = Decimal.ToByte(right);
                byte byteAnswer = Decimal.ToByte(answer);
                outputStr = $"{byteLeft}{oP}{byteRight}{" = "}{byteAnswer}";
                lbl_Output.Text = outputStr;
            }
            catch (OverflowException) { Error(2); Error(0); }
        }
    }

As you are using these bools fields as flags you are maybe better off using an Enum instead... For saving lines Rans answer may help or you create a method in which you pass... - an enum or a string maybe? — ChriPf
– ChriPf, Commented Nov 23, 2021 at 19:39
Thank you. I think I'll use his for now, and hold off to see if anyone comes up with anything shorter. I'm obviously still learning C# so I'm not too comfortable with Enum. My code currently works as is, I don't want to break it with things I don't know how to use properly. — KyleC
– KyleC, Commented Nov 23, 2021 at 19:43

pho · Accepted Answer · 2021-11-23 19:41:34Z

3

This could be a good use-case for an Enum.

Define an Enum like so:

public Enum ClickType 
{
    None,
    Byte,
    Short,
    Int,
    Long,
    Float,
    Double,
    Decimal
}

Add a field to the class that contains the event handlers:

private ClickType clickType;

Then, in the event handler, set this field:

private void btn_Byte_Click(object sender, EventArgs e)
{
    this.clickType = ClickType.Byte;
}

And in the postProcess() method, do:

public void PostProcess(decimal left, decimal right, decimal answer, string oP)
{
    ...
    // Or replace this with a switch-case
    if (this.clickType == ClickType.Byte)
    {
        ...
    }
    ...
}

answered Nov 23, 2021 at 19:41

pho

25.7k8 gold badges48 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ran Turner · Accepted Answer · 2021-11-23 19:38:40Z

1

You could write it the following way

    byteClick = true;
    shortClick = intClick = longClick = floatClick = douClick = decClick = false;

answered Nov 23, 2021 at 19:38

Ran Turner

18.7k9 gold badges60 silver badges60 bronze badges

1 Comment

Ran Turner Over a year ago

@KyleC was this answer helpful?

Collectives™ on Stack Overflow

Can I edit multiple array values in one line in C#

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related