Cleanest way to iterate through a loop in Ruby, while outputting two values?

Question

I have a simple loop, which is fed an Array with multiple elements, the goal of my function is to iterate over each element, with the value of ID to be the same as the ID of the element currently in the loop and the value of 'body' to be that of the entire same element.

I'm struggling to ensure that the loop resets and feeds in a new element every iteration, rather than one or the other remaining in the loop.

What would be the best way to achieve this?

@data = [{ 'url' => 'https://zendesk.com/api/v2/macros/1900002708354.json',
           'id' => 1_900_002_708_354,
           'actions' => [{ 'field' => 'comment_value_html', 'value' => '{{email}} 360081752739' }],
           'restriction' => nil },
         { 'url' => 'https://zendesk.com/api/v2/macros/360081752739.json',
           'id' => 360_081_752_739,
           'actions' => [{ 'field' => 'comment_value_html', 'value' => '{{IBAN}} ' }],
           'restriction' => nil },
         { 'url' => 'https://zendesk.com/api/v2/macros/360081755559.json',
           'id' => 360_081_755_559,
           'actions' => [{ 'field' => 'comment_value_html', 'value' => '{{email}} 360081752739' }],
           'restriction' => nil }]





def run_function
  @data.each do |x|
    @id = [x.select { |m| m['id'] }]
    final_data = x
    body = final_data
    puts body
  end
 end

My ID variable currently outputs as [{"id"=>1900002708354}], whereas I only require the number.

For the love of god, please indent the code properly. Otherwise the code becomes impossible to scan. — Sergio Tulentsev
– Sergio Tulentsev, Commented Nov 25, 2021 at 20:37
In this particular case, the body of the each should be indented by one level. — Sergio Tulentsev
– Sergio Tulentsev, Commented Nov 25, 2021 at 20:38
Perfect. Now, I have questions about the code. Not sure what you attempted to do with @data.select { |m| m['actions'] }.map { |m| m['id'] }, but it most certainly is not doing what you think it does. It'll have the same value (a list of all ids) at each iteration. In particular, .select { |m| m['actions'] } is useless (given the provided input array) — Sergio Tulentsev
– Sergio Tulentsev, Commented Nov 25, 2021 at 20:43
@cbin1 : Since @data is an array of Hashes, x must be a Hash. What's the point in applying select to a Hash? — user1934428
– user1934428, Commented Nov 26, 2021 at 8:36

Matheus Moreira · Accepted Answer · 2021-11-25 23:30:42Z

1

@data.each do |hash|
  id = hash['id']
  puts id
end

answered Nov 25, 2021 at 23:30

Matheus Moreira

17.1k3 gold badges73 silver badges112 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Cleanest way to iterate through a loop in Ruby, while outputting two values?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related