can't get value from onclick function javascript

Question

I have a function where I am trying to get a value from an onclick event.

Here is the element attribute that gives the function to the element:

listcontainer.setAttribute('onmousedown',"knowbe4campaignspecific(this)")

Here is the function code:

function knowbe4campaignspecific(ele){
    console.log(ele.value)}

However it will say undefined in the developer console.

If I just print the element by itself it will show the value inside so I must be missing something basic.

function knowbe4campaignspecific(ele){
    console.log(ele)}

##RESULTS##
<ul value="183085" onmousedown="knowbe4campaignspecific(this)" class="ms-List"></ul>

Let me know if anything else is needed and I will update this post. Thanks!

<ul> elements do not have a value property. You may be interested in data attributes if you want to assign and access arbitrary data — Phil
– Phil, Commented Dec 5, 2021 at 23:13

Kinglish · Accepted Answer · 2021-12-05 23:21:13Z

2

As mentioned, value isn't a valid attribute of <ul>. You can still use it and access it through element.getAttribute but using datasets is more extendable and the correct implementation - you can access those through element.dataset

document.querySelector('.ms-List').setAttribute('onmousedown',"knowbe4campaignspecific(this)")

function knowbe4campaignspecific(ele){
    console.log(ele.getAttribute('value'))
    console.log(ele.dataset.value)
}

<ul value="183085" data-value="This is the better way" class="ms-List"><li> something</li></ul>

answered Dec 5, 2021 at 23:21

Kinglish

23.7k4 gold badges25 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user16953756 Over a year ago

Thank you for helping me out as well! I think learned a little more from you since I learned you can use element.getAttribute to find value. I am using datasets now as that seems great, but I just wanted to say thanks for that extra bit of information :)

Antoine Gagnon · Accepted Answer · 2021-12-05 23:20:43Z

0

On elements that are not inputs you want to use the data attribute.

I believe this should work

<ul data-value="183085" onmousedown="knowbe4campaignspecific(this)" class="ms-List"></ul>

And then

function knowbe4campaignspecific(ele){
    console.log(ele.dataset.value)}

answered Dec 5, 2021 at 23:20

Antoine Gagnon

9928 silver badges14 bronze badges

Collectives™ on Stack Overflow

can't get value from onclick function javascript

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related