array_push replacing value instead of adding new value in array

Question

I'm trying to make a cart system, which is I need to sum all total product. I'm thinking about saving the total to an array, so I can use array_sum it later. But somehow the array $total_cart[] only have last total, for example is if I have three product in my cart, the total saved in the array is only from the third not all product that I have. And the total value is from calculation $price_discount * $cart_item['quantity'];

foreach ($cart_decode as $key => $cart_item):
    $product = \App\Models\Product::where('id', $cart_item['product_id'])->first();
    $discount = ($product->price * $product->discount) / 100;
    $price_discount = $product->price - $discount;

    $total_cart = array();
    $total_cart[] = $price_discount * $cart_item['quantity'];
endforeach

It's because you reset the array on every iteration. Move $total_cart = array(); outside the foreach loop — Marco
– Marco, Commented Dec 13, 2021 at 2:23

Lee · Accepted Answer · 2021-12-13 02:25:09Z

3

$total_cart = array(); is in a loop so it reset every time.

You should put $total_cart = array(); before foreach.

answered Dec 13, 2021 at 2:25

Lee

4182 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Catto Over a year ago

Thanks for your help, now it's working correctly

Muhammad Dyas Yaskur · Accepted Answer · 2021-12-13 02:24:38Z

3

Your code creates/defines a new array in every single loop. You should define $total_cart before the looping/foreach.

$total_cart = array();
    foreach ($cart_decode as $key => $cart_item):
        $product = \App\Models\Product::where('id', $cart_item['product_id'])->first();
        $discount = ($product->price * $product->discount) / 100;
        $price_discount = $product->price - $discount;
    
        $total_cart[] = $price_discount * $cart_item['quantity'];
    endforeach

answered Dec 13, 2021 at 2:24

Muhammad Dyas Yaskur

8,34811 gold badges62 silver badges91 bronze badges

1 Comment

Catto Over a year ago

Thanks for your help, now it's working correctly

Collectives™ on Stack Overflow

array_push replacing value instead of adding new value in array

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related