Why are loop generated Bash array values concatenated together?

Question

I'm writing a short script to automate output filenames. The testing folder has the following files:

test_file_1.fa
test_file_2.fa
test_file_3.fa

So far, I have the following:

#!/bin/bash

filenames=$(ls *.fa*)
output_filenames=$()
output_suffix=".output.faa"

for name in $filenames
do
        output_filenames+=$name$output_suffix
done

for name in $output_filenames
do 
        echo $name
done

The output for this is:

test_file_1.fa.output.faatest_file_2.fa.output.faatest_file_3.fa.output.faa

Why does this loop 'stick' all of the filenames together as one array variable?

You didn't define any arrays. output_filenames=()

chepner
– chepner

2021-12-13 13:26:05 +00:00
Commented Dec 13, 2021 at 13:26 — chepner
– chepner, Commented Dec 13, 2021 at 13:26

glenn jackman · Accepted Answer · 2021-12-13 13:22:41Z

4

shell arrays require particular syntax.

output_filenames=()            # not $()
output_suffix=".output.faa"

for name in *.fa*              # don't parse `ls`
do
        output_filenames+=("$name$output_suffix")   # parentheses required
done

for name in "${output_filenames[@]}"    # braces and index and quotes required
do 
        echo "$name"
done

https://tldp.org/LDP/abs/html/arrays.html has more examples of using arrays.

"Don't parse ls" => https://mywiki.wooledge.org/ParsingLs

answered Dec 13, 2021 at 13:22

glenn jackman

249k42 gold badges233 silver badges362 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Why are loop generated Bash array values concatenated together?

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related