Getting MissingMethodInvocationException while testing with servlet and session

Question

I'm trying to test my servlet to see if it calls my DAOService with some passed parameters from the session but running into this problem

The log:

org.mockito.exceptions.misusing.MissingMethodInvocationException: 
when() requires an argument which has to be 'a method call on a mock'.
For example:
    when(mock.getArticles()).thenReturn(articles);
at Servlet.SupplierServletTest.supplierServlet_StandardTest(SupplierServletTest.java:32)

The code

SupplierServlet supplierServlet = new SupplierServlet();
MockHttpServletRequest request = new MockMvcRequestBuilders.get("/SupplierServlet").buildRequest(new MockServletContext());
MockHttpServletResponse response = new MockHttpServletResponse();
MockHttpSession session = new MockHttpSession();

when(request.getSession()).thenReturn(session); //This is the line 32 that the log mentioned, I deleted the session part and the problem was the same for the following lines
when(request.getParameter("Name")).thenReturn("test"); 
when(request.getParameter("Address")).thenReturn("test");
when(request.getParameter("Phone")).thenReturn("1234");

supplierServlet.processRequest(request, response);
supplierDAO = mock(SupplierDAO.class);
verify(supplierDAO).newSupplier(new Supplier("test", "test", "1234"));

Any tip is appreciated

I was using that mock from Spring test as someone suggested in my previous question. I'm trying to do things in Mockito's way right now to see if there's any improvement, but the initiation so far is a pain — Long Doan
– Long Doan, Commented Dec 20, 2021 at 9:07
just use addParameter()javadoc (exclusive!)OR use Mockio... — xerx593
– xerx593, Commented Dec 20, 2021 at 9:18

ashu · Accepted Answer · 2021-12-20 09:33:12Z

1

As for initialising MockHttpServletRequest, you should use the Spring provided builder. Since it is a class offered by the Spring framework (and is not a Mockito mock), using Mockito to mock its methods will result in an error.

MockHttpServletResponse response = new MockHttpServletResponse();
MockHttpSession session = new MockHttpSession();
MockHttpServletRequest request = MockMvcRequestBuilders.get("/SupplierServlet")
    .session(session)
    .param("Name", "test")
    .param("Address", "test")
    .param("Phone", "1234")
    .buildRequest(new MockServletContext());

supplierServlet.processRequest(request, response);
supplierDAO = mock(SupplierDAO.class);
verify(supplierDAO).newSupplier(new Supplier("test", "test", "1234"));

Moreover, your supplierDAO mock is useless. After mocking an object, you need to inject it into the code under test. It is usually done by passing the mock as a function parameter. Whereas in your test, you're trying to verify calls on a mock that was never used.

edited Dec 20, 2021 at 9:33

answered Dec 20, 2021 at 9:26

ashu

1,8664 gold badges25 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Long Doan Over a year ago

Thank you, the supplierDAO part is to verify whether if it's called since it should be called if the servlet works as intended in the test

ashu Over a year ago

@LongDoan Yes, but the SupplierDAO (mock) instance in your test code is independent of the SupplierDAO instance in your servlet. You cannot verify calls on a (mocked) instance unless your servlet also uses the same instance.

Taner · Accepted Answer · 2024-12-21 05:21:44Z

Use mocks mocked by Mockito if you need to mock the behavior.

I was facing with the same error with following test method;

@Test
void testLogicWhenHttpCallShouldForwardToHttp() {
    //Given
    HttpServletRequest request = new MockHttpServletRequest();
    HttpServletResponse response = new MockHttpServletResponse();
    String url = "www.testdomain.com/api/route";

    //When
    Mockito.when(request.getRequestURL()).thenReturn(new StringBuffer("https://" + url));

    //... rest of the code
}

Fixed it by changing the mocking as said above;

@Test
void testLogicWhenHttpCallShouldForwardToHttp() {
    //Given
    HttpServletRequest request = Mockito.mock(HttpServletRequest.class);
    HttpServletResponse response = Mockito.mock(HttpServletResponse.class);
    String url = "www.testdomain.com/api/route";

    //When
    Mockito.when(request.getRequestURL()).thenReturn(new StringBuffer("https://" + url));

    //... rest of the code
}

Collectives™ on Stack Overflow

Getting MissingMethodInvocationException while testing with servlet and session

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related