Error in PHP code to construct URL

Question

I need to fix this URL redirect in header

$siteurl = http://myfirstsite.com
$siteurl2 = http://mysecondsite.com

<a href="<?php echo if (strstr ($_SERVER["REQUEST_URI"], "hus")) {
    echo $siteurl;
} else {
    echo $siteurl2;
}."/".ereg_replace(" ", "-", $show_wallpaper["caturl"])."-".$show_wallpaper["categoryid"]."-"."1.php"; ?>">

It throws an error now.

Michael Berkowski · Accepted Answer · 2011-08-12 15:05:16Z

2

You are concatenating against the braces of an if block {}. Instead, echo:

<a href="<?php echo if (strstr ($_SERVER["REQUEST_URI"], "hus")) {
    echo $siteurl;
} else {
    echo $siteurl2;
}
echo "/".ereg_replace(" ", "-", $show_wallpaper["caturl"])."-".$show_wallpaper["categoryid"]."-"."1.php"; 
?>">

answered Aug 12, 2011 at 15:05

Michael Berkowski

271k47 gold badges450 silver badges395 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marc B · Accepted Answer · 2011-08-12 15:15:27Z

0

First off, don't use ereg functions. They're deprecated. Use the preg functions instead.

preg_replace('/ /', '-', ...);

Beyond that, the fix is trivial:

if (...) {
   header('Location: ' . $siteurl . preg_replace(...));
} else {
   header('Location: ' . $siteurl2 . preg_replace(...));
}

edited Aug 12, 2011 at 15:15

answered Aug 12, 2011 at 15:05

Marc B

362k44 gold badges433 silver badges508 bronze badges

2 Comments

HAS Over a year ago

i use like this

<a href="<?php if (strstr ($_SERVER["REQUEST_URI"], "hus")) {    header('Location: ' . $siteurl . preg_replace(" ", "-", $show_wallpaper["caturl"])."-".$show_wallpaper["categoryid"]."-"."1.php")); } else {    header('Location: ' . $siteurl2 . preg_replace(" ", "-", $show_wallpaper["caturl"])."-".$show_wallpaper["categoryid"]."-"."1.php")); } ?>">

Marc B Over a year ago

preg requires delimiters around the regex. '/ /', not " " as you have.

Collectives™ on Stack Overflow

Error in PHP code to construct URL

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related