javascript variable in string

Question

I'm struggling with this Javascript:

 width = screen.width * .75;
 height = screen.height * .75;

$(".colorbox").colorbox({
  width:"800px", 
  height:"600px", 
  iframe:true, 
  scrolling:false});

I am trying to put the values of width and height into the 800 and 600 spots, respectively.

Peter Olson · Accepted Answer · 2011-08-15 04:46:16Z

3

This is pretty straightforward to fix:

var width = screen.width * .75; 
var height = screen.height * .75;

$(".colorbox").colorbox({
  width: width, 
  height: height, 
  iframe: true, 
  scrolling: false});

(Just a side note, put var before your variable declarations, or else they will become global, perhaps unintentionally).

edited Aug 15, 2011 at 4:46

answered Aug 15, 2011 at 4:39

Peter Olson

144k49 gold badges209 silver badges249 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

karim79 Over a year ago

+1 but pretty please suggest the use of var and that globals are bad, etc. ;)

Ray Toal Over a year ago

Or just width: screen.width * 0.75; etc. to avoid the possibility of globals completely.

Stephen · Accepted Answer · 2011-08-15 04:41:16Z

1

Colorbox actually supports specifying the widths as integers or with a unit..

So,

$(".colobox").colorbox({
  "width": width,
  "height": height
});

answered Aug 15, 2011 at 4:41

Stephen

3,4421 gold badge24 silver badges22 bronze badges

Collectives™ on Stack Overflow

javascript variable in string

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related