Yes or No while loop for a 2d array doesn't print array in C

Question

I'm new to c and don't really understand how 2d arrays work. When the code is executed it prompts for me to enter a course and then when the loop is broken the print statement doesn't show what I inputted.

    #include <stdio.h>
    #include <stdlib.h>
    #include <string.h>

    int main()

   {

   char courses[60][100];
   char ans ='y';
   int  i=0;
   int p,j;

   while (ans == 'y'){
   printf("Enter course:\n");
   for (p=0;p<j;p++)
   scanf("%s", &courses[p]);
   getchar(); 

   i++;

  printf("Would you like to enter another course? (y or n) \n"); 
  ans = getchar();

 }
 printf("courses are %s",courses[p]);
 }

You created an array of characters and not pointers. Pointers are used to reference “strings” of characters. I’m not sure what j does and is currently not set or manipulated so you’ll likely run into storage corruption. — Hogstrom
– Hogstrom, Commented Jan 7, 2022 at 20:36
printf("courses are %s",courses[p]) outputs one string, but the code does not enter any data for courses[p], only up to courses[p-1]. — Weather Vane
– Weather Vane, Commented Jan 7, 2022 at 20:39
In addition to the unintialised j value, the last printf is also wrong. p is not a valid index at that point and if you want to print out all the courses you need another for loop to print each of the courses strings. — kaylum
– kaylum, Commented Jan 7, 2022 at 20:40

0___________ · Accepted Answer · 2022-01-07 21:02:58Z

1

int main()
{
    char courses[60][100];
    char ans ='y';
    size_t  i = 0;

    do
    {
        printf("Enter course:\n");
        scanf("%99s", courses[i]);
        getchar(); 
        i++;
        printf("Would you like to enter another course? (y or n) \n"); 
        ans = getchar();
    }while(ans == 'y');
    for(size_t p = 0; p < i; p++)
        printf("courses are %s\n",courses[p]);
}

https://godbolt.org/z/EKqEq8aos

edited Jan 7, 2022 at 21:02

answered Jan 7, 2022 at 20:48

0___________

71.6k4 gold badges41 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

0___________ Over a year ago

@chux-ReinstateMonica and courses[i] not &courses[i]. Copy paste

Collectives™ on Stack Overflow

Yes or No while loop for a 2d array doesn't print array in C

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related