C# Custom Validation Attributes: Comparing two Dates in the same model

Question

I created a Custom Validation class that inherits form ValidationAttibute Class. It ensures past dates cannot be selected. Now I have a second date that needs to be at least 3 days after first date. What's the best approach to compare both dates and proceed only if second Date 3 days later than first date (Termination Date and Archiving Date)

This is the code I have for the first date

public class CustomTerminationDate : ValidationAttribute
{
    public override bool IsValid(object value)
    {
        DateTime dateTime = Convert.ToDateTime(value);
        return dateTime >= DateTime.Now.Date;
    }
}

It gets implemented as follow:

[Required, Display(Name = "Termination Date")]
    [DataType(DataType.Date)]
    [CustomTerminationDate(ErrorMessage = "Termination Date can not be in the past")]        
    public DateTime TerminationDate { get; set; }

IMHO cross field validation should be in an IValidatableObject implementation. — Jeremy Lakeman
– Jeremy Lakeman, Commented Jan 10, 2022 at 2:55
Jeremy please post it to accept as answer. this resolved the issue. — Hector Marcia
– Hector Marcia, Commented Jan 10, 2022 at 3:46

Jeremy Lakeman · Accepted Answer · 2022-01-10 03:57:00Z

2

Validation attributes are great for validating a single property. I wouldn't attempt to validate multiple properties with attributes, since you can't be certain in what order the fields will be assigned and when the validation should occur.

Instead I would implement IValidatableObject;

public class YourClass: IValidatableObject
{
    public IEnumerable<ValidationResult> Validate(ValidationContext validationContext)
    {
        if (TerminationDate < OtherDate + TimeSpan.FromDays(3))
            yield return new ValidationResult("... error message here ...");
    }
}

answered Jan 10, 2022 at 3:57

Jeremy Lakeman

11.6k30 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C# Custom Validation Attributes: Comparing two Dates in the same model

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related