Problem when running SQL query

Question

foreach (DataRow masterRow in dst.Tables["Menu"].Rows)
{
  MenuItem masterItem = new MenuItem((string)masterRow["Parentitem"]);
  string mp = masterItem.Value;

  SqlParameter parameter = new SqlParameter();
  parameter.ParameterName = "@mp";
  parameter.SqlDbType = SqlDbType.NVarChar;
  parameter.Direction = ParameterDirection.Input;
  parameter.Value = mp;

  string q = "select aspnet_PersonalizationPerUser.hasRights 
              from Menu,aspnet_Users,aspnet_Paths, aspnet_PersonalizationPerUser 
              where  Menu.Parentitem=@mp and Menu.Url = aspnet_Paths.Path 
                     and aspnet_Paths.PathId =aspnet_PersonalizationPerUser.PathId 
                     and aspnet_Users.UserName ='admin' 
                     and aspnet_PersonalizationPerUser.UserId = aspnet_Users.userId ";

   SqlCommand cm = new SqlCommand(q, conn);
   string b = (string)cm.ExecuteScalar();
   if (b == "true")
   {
        Menu1.Items.Add(masterItem);
   }

So when I run the app it says need to declare scalar variable mp .. can u let me know the mistake?

try mp without the @ in the parameterName

Martin
– Martin

2011-08-15 19:07:00 +00:00
Commented Aug 15, 2011 at 19:07 — Martin
– Martin, Commented Aug 15, 2011 at 19:07

Jeff · Accepted Answer · 2011-08-15 19:14:29Z

3

You need to add the parameter to the command.

SqlCommand cm = new SqlCommand(q, conn);
cmd.Parameters.Add(parameter);
string b = (string)cm.ExecuteScalar();

answered Aug 15, 2011 at 19:14

Jeff

14.3k12 gold badges61 silver badges107 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ChrisLively · Accepted Answer · 2011-08-15 19:13:42Z

1

You need to actually add the parameter to the SqlCommand object.

Off the top of my head I think its something like:

cm.Parameters.Add(parameter);

Do this before you call ExecuteScalar

answered Aug 15, 2011 at 19:13

ChrisLively

88.3k27 gold badges174 silver badges249 bronze badges

Comments

alun · Accepted Answer · 2011-08-15 19:13:48Z

1

You are just creating a parameter, not adding it to your command. Try adding this before executing the command:

cm.Parameters.Add(parameter);

answered Aug 15, 2011 at 19:13

alun

3,46123 silver badges26 bronze badges

Comments

marc_s · Accepted Answer · 2011-08-15 19:15:16Z

0

You have forgot to add the parameter @mp to your command

cm.Parameters.Add(parameter)

edited Aug 15, 2011 at 19:15

marc_s

760k186 gold badges1.4k silver badges1.5k bronze badges

answered Aug 15, 2011 at 19:07

Martin

1,5363 gold badges18 silver badges36 bronze badges

1 Comment

user838359 Over a year ago

do u mean this way... parameter.ParameterName = "mp";

Collectives™ on Stack Overflow

Problem when running SQL query

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related