mysql command not executing using php

Question

For some reason my sql query is not executing and the error message is not printing in php. Here is the code:

    mysql_connect("$host", "$username", "$password")or die("cannot connect");
    mysql_select_db("$db_name")or die("cannot select DB");

    $sql = "DELETE FROM data WHERE id='".$_GET['id']."'";
    echo $sql;
    $result=mysql_db_query($sql);
    if(!$result) {
        $msg = "ERROR: ". mysql_error();
        echo $msg;
    }

I know its vulnerable for sql injection right now but im going to fix that after i get it working. Also, if i copy what $sql prints and paste it into phpmyadmin it works and it does go into the if statement.

Have you activated display_errors and ajusted your error_reporting level? — plandolt
– plandolt, Commented Aug 15, 2011 at 21:39
also, the first argument of mysql_db_query is supposed to be the database connection, not the query. — dqhendricks
– dqhendricks, Commented Aug 15, 2011 at 21:40
foo.php?id=' OR 1=1 -- I just deleted all records in your data table. Please read up on SQL injection, then go learn PDO. — Charles
– Charles, Commented Aug 15, 2011 at 21:43

wonk0 · Accepted Answer · 2011-08-15 21:39:13Z

2

You want to use mysql_query(), not mysql_db_query().

And why do you enclose all your variables in quotes?

answered Aug 15, 2011 at 21:39

wonk0

14.1k1 gold badge23 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ldiqual · Accepted Answer · 2011-08-15 21:38:45Z

1

Use mysql_query() instead of mysql_db_query() which is deprecated.

answered Aug 15, 2011 at 21:38

ldiqual

15.4k7 gold badges55 silver badges94 bronze badges

1 Comment

user776530 Over a year ago

i was using mysql_query() and it wasn't working so i tried out mysql_db_query() out of desperation and just forgot to swith it back before posting.

Hassan Khodadadeh · Accepted Answer · 2011-08-15 21:39:53Z

0

http://www.php.net/manual/en/function.mysql-db-query.php

mysql_db_query

This function has been DEPRECATED as of PHP 5.3.0. Relying on this feature is highly discouraged.

instead use mysql_query

answered Aug 15, 2011 at 21:39

Hassan Khodadadeh

7,8984 gold badges47 silver badges72 bronze badges

Collectives™ on Stack Overflow

mysql command not executing using php

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related