Saving objects to an array and printing stored object data

Question

I have this method created to ask a user to input job details, and save to an array:

public static void addJob() { currentJobIndex = 0;

    jobs[currentJobIndex] = new Job();
    jobs[currentJobIndex].getInformation();
    jobs[currentJobIndex].calculateCost();
    jobs[currentJobIndex].display();
    jobs[currentJobIndex].getCostTotal();
    currentJobIndex++;

I have this method to display all jobs saved in the array:

public static void showAllJobs() {

    for (Job job : jobs) {
        if (job != null) {
            job.display();
        }
    }

}

It is only showing the last entered job and I cant figure out why, any assistance would be appreciated!

When you use the addJob() method you have currentJobIndex = 0; so items will only ever be inserted al position 0 (and will overwrite anything else that was there). You need to increment this number and ensure that your array has space. You should probably be using an ArrayList that already has an add method. — sorifiend
– sorifiend, Commented Jan 27, 2022 at 21:38
Thank you, removing the currentJobIndex = 0; resolved the issue! — cattedad
– cattedad, Commented Jan 27, 2022 at 21:42

Timo · Accepted Answer · 2022-01-27 21:40:21Z

0

This is because every time you call the method, currentJobIndex = 0; is executed again, so you do not go to the next position in the array, but always write to jobs[0]. currentJobIndex needs to be a global variable, like this:

public class Job(){
   private int[] jobs = new int[5]; // Specify length of array here.
   private currentJobIndex = 0;

   public void addJob(){
    jobs[currentJobIndex] = new Job();
    jobs[currentJobIndex].getInformation();
    jobs[currentJobIndex].calculateCost();
    jobs[currentJobIndex].display();
    jobs[currentJobIndex].getCostTotal();
    currentJobIndex++;
   }
}

(Sidenote: Since you probably don't know how many jobs will be stored in advance, a list would be the better choice here.)

answered Jan 27, 2022 at 21:40

Timo

3163 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

PJMan0300 · Accepted Answer · 2022-01-27 21:45:18Z

-1

This is because currentJobIndex doesn't increment when you add a new job.

You can fix this by adding:

public static void addJob() { currentJobIndex = 0;

    jobs[currentJobIndex] = new Job();
    jobs[currentJobIndex].getInformation();
    jobs[currentJobIndex].calculateCost();
    jobs[currentJobIndex].display();
    jobs[currentJobIndex].getCostTotal();

    currentJobIndex++;

     }

answered Jan 27, 2022 at 21:45

PJMan0300

765 bronze badges

1 Comment

sorifiend Over a year ago

This will not solve the problem. currentJobIndex will still be set to 0 every time the method is called.

Collectives™ on Stack Overflow

Saving objects to an array and printing stored object data

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related