How to pass three parameters to url address using ASP.NET Core Web API

Question

For now I have a procedure I wish to call:

CALL Get_Discharge_Station('2022-02-02', 6, 11800);

I want to pass these three parameters - 2022-02-02,6,11800 to url address, when I enter different date,number and number of station to get different data.

For now my API controller look like this:

using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Configuration;
using MySql.Data.MySqlClient;
using System;
using System.Collections.Generic;
using System.Data;
using System.Linq;
using System.Threading.Tasks;

namespace WebAPI.Controllers
{
    [Route("api/hqdataahs")]
    [ApiController]
    public class HQ_data_AHSController : ControllerBase
    {
        private readonly IConfiguration _configuration;

        public HQ_data_AHSController(IConfiguration configuration)
        {
            _configuration = configuration;
        }

        [HttpGet]
        public JsonResult Get()
        {
            string query = @"CALL Get_Discharge_Station('2022-02-02', 6, 11800);";

            DataTable table = new DataTable();

            string sqlDataSource = _configuration.GetConnectionString("AppCon");

            MySqlDataReader myReader;

            using (MySqlConnection mycon = new MySqlConnection(sqlDataSource))
            {
                mycon.Open();

                using (MySqlCommand myCommand = new MySqlCommand(query, mycon))
                {
                    myReader = myCommand.ExecuteReader();
                    table.Load(myReader);

                    myReader.Close();
                    mycon.Close();
                }
            }

            return new JsonResult(table);
        }
    }
}

What can I change to pass there three parameters in url address when I access the controller?`

Your code is vulnerable to SQL injection, you should use parameterized queries to be secure: dev.mysql.com/doc/connector-net/en/… — DA_123
– DA_123, Commented Feb 13, 2022 at 19:43

Serge · Accepted Answer · 2022-02-13 20:14:14Z

2

just fix the action

 [HttpGet("~/api/hqdataahs/GetData")]
  //or just
 [HttpGet("GetData")]
 public JsonResult Get(string date, int num, int statNum)
{
    string query = $"CALL Get_Discharge_Station('{date}', {num}, {statNum});";
    .....

and carefully read all comments below about sql injection.

you url should be

https://.../api/hqdataahs/GetData?date=2022-02-02&num=6&statNum=11800

or change route

 [HttpGet("~/api/hqdataahs/GetData/{date}/{num}/{statNum}")]
  //or just
 [HttpGet("GetData/{date}/{num}/{statNum}")]
[HttpGet("~api/hqdataahs/GetData
 public JsonResult Get(string date, int num, int statNum)

in this case you url should be

https://.../api/hqdataahs/GetData/2022-02-02/6/11800

edited Feb 13, 2022 at 20:14

answered Feb 13, 2022 at 19:39

Serge

44.4k4 gold badges26 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Ben Johnson Over a year ago

I try with your method but my route is [Route("api/hqdataahs")], how to access the API page ?

Serge Over a year ago

@BenJohnson Just don forget that route should start with "~/" [Route("~/.. and you can select for the route any words that you like, it should be the same for url

Ben Johnson Over a year ago

How to be api/hqdataahs/GetData?date=2022-02-02&num=6&staNum=11800 ?

Ben Johnson Over a year ago

Can you change your answer like that, please

pm100 · Accepted Answer · 2022-02-13 19:35:30Z

1

declare the args

    [HttpGet]
    public JsonResult Get(string dataStr, int noodle, int frumpy)
    {

now construct the call

  string query = $"CALL Get_Discharge_Station('{dateStr}', {noodle}, {fumpy});"

answered Feb 13, 2022 at 19:35

pm100

50.6k25 gold badges95 silver badges158 bronze badges

3 Comments

Ben Johnson Over a year ago

How to call after that ?

pm100 Over a year ago

@BenJohnson see serge answer

Ben Johnson Over a year ago

Ok but my route is different

Collectives™ on Stack Overflow

How to pass three parameters to url address using ASP.NET Core Web API

2 Answers 2

4 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related