C# properties, constructor,

Question

I want to create class that draws a board. I wrote code like this (it works):

{
public class Map
{
    public int rows { get; set; }
    public int cols { get; set; }
    public int[,] grid { get; set; }

    public Map(int rows, int cols)
    {
        this.rows = rows;
        this.cols = cols;
        this.grid = new int[rows, cols];
    }
    public void printBoard()
    {
        for (int r = 0; r < rows; r++)
        {
            for (int c = 0; c < cols; c++)

            {
                Console.Write(grid[r, c] + "");
            }
            Console.WriteLine();
        }
    }
}
//Program.cs: 
Map map = new Map(2, 2); map.printBoard();

Questions i have: 1.Can I create array as property and then initialize it(idk how to call it) in constructor as in the code above? I read here that i shoud't do it but maby that was not the case https://stackoverflow.com/a/18428679 2. If it's ok, is it good practice to write code like this, maby I coud write it better?

Yes, you can do this. It would be better to remove the set; accessors, otherwise the user of the object could change e.g. the value of rows and the array will not reflect this. — Klaus Gütter
– Klaus Gütter, Commented Feb 17, 2022 at 12:25
The answer you linked just warns that any user of the class can change the contents of your grid without the class being aware of this. This might or might not be an issue. — Klaus Gütter
– Klaus Gütter, Commented Feb 17, 2022 at 12:27

PMF · Accepted Answer · 2022-02-17 12:31:24Z

1

As described in the answer you link to, properties should not normally return arrays, because that exposes the internals of a class to the outside, without the control over what is part of the array. The way you have declared your property, a client can insert arbitrary values into the array and your class has no way of performing any validation.

By convention, properties should use capital names as well. But in your case, the right thing to do is make all your properties fields and make them private. Then add an indexer to update the array (Note that it is even possible to change rows and cols from outside, which will most certainly result in undefined behavior).

answered Feb 17, 2022 at 12:31

PMF

17.6k4 gold badges32 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Pekler Over a year ago

Thank you for answer, now i see what shoud i do :)

Collectives™ on Stack Overflow

C# properties, constructor,

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related