Both if and else block are executed in Batch script

Question

I am new to Batch scripting. I am trying to write a script which parses given command and check if argument with name 'folder 'is present in that command and if not , add that argument with default value.

I have written following script. This scripts executes correctly if argument is missing. But if argument is present , both if and else blocks are executed.

Please help. Thanks in advance.

@echo off

set ARGS=-action generate -folder "Source"
set t=%ARGS%

echo %t%|find "-folder" >nul
if errorlevel 1 (
    goto setDefaultFolder
) else (
    echo Folder is specified in command
)

:setDefaultFolder
echo Folder is NOT specified in command. User's current directory will be used as Folder.
set folderArgName=-folder
set folderArgValue="%cd%"
set folderArg=%folderArgName% %folderArgValue%
echo folderArgName : %folderArgName%
echo folderArgValue : %folderArgValue%
echo folderArg: %folderArg%
set ARGS=%ARGS% %folderArg%
echo ARGS : %ARGS%

Output of code :

Folder is specified in command
Folder is NOT specified in command. User's current directory will be used as Folder.
folderArgName : -folder
folderArgValue : "C:\work"
folderArg: -folder "C:\work"
ARGS : -action generate -folder "Source" -folder "C:\work"

Batch scripts are executed line by line. The else should not execute on the if being true, however the label setdefaultfolder will execute even if the if condition is false unless you implement a sctipt break prior to the label. — T3RR0R
– T3RR0R, Commented Feb 22, 2022 at 9:49

Dijkgraaf · Accepted Answer · 2022-02-22 09:49:35Z

3

You have to have a goto in the else, that goes to after the setDeafultFolder, otherwise it just will execute the setDefaultFolder after it

@echo off

set ARGS=-action generate -folder "Source"
set t=%ARGS%

echo %t%|find "-folder" >nul
if errorlevel 1 (
    goto setDefaultFolder
) else (
    echo Folder is specified in command
    goto endOfBatch
)

:setDefaultFolder
echo Folder is NOT specified in command. User's current directory will be used as Folder.
set folderArgName=-folder
set folderArgValue="%cd%"
set folderArg=%folderArgName% %folderArgValue%
echo folderArgName : %folderArgName%
echo folderArgValue : %folderArgValue%
echo folderArg: %folderArg%
set ARGS=%ARGS% %folderArg%
echo ARGS : %ARGS%

:endOfBatch

answered Feb 22, 2022 at 9:49

Dijkgraaf

11.5k18 gold badges46 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Both if and else block are executed in Batch script

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related