Java array: Finding index always returns the highest

Question

Part of one of our assignments was to generate an array and then find the sum, average, lowest, and highest values. I have all of those working, but our teacher has asked us instead to return the index of the highest and lowest values plus one (to coincide with a month number).

The issue I'm running into is that trying to return the index it always returns the highest value.

public double getHighRain()
{
    double high = 0.0;
    double highIndex = 0.0;
    
    for(int index = 1; index < rainFall.length; index++)
    {
        if (rainFall[index] > high)
            high = rainFall[index];
            highIndex = index + 1;
    }
        //return high;
        return highIndex;
}
/**
 * Method uses enhanced for loop to calculate the lowest amount of rainfall
 * @return 
 */
public double getLowRain()
{
    double low = rainFall[0];
    double lowIndex = 0.0;
    
    for(int index = 1; index < rainFall.length; index++)
    {
        if (rainFall[index] < low)
            low = rainFall[index];
            lowIndex = index + 1;
    }
        //return low;
        return lowIndex;
}

In getHighRain, why do you start at index 1 and skip the first element in that array? — Chris
– Chris, Commented Feb 23, 2022 at 21:22
Java doesn't use indentation for control structures. You need a block after your if condition to contain the following two lines. Learn to use the debugger, stepping through your code would have shown you the problem. — tgdavies
– tgdavies, Commented Feb 23, 2022 at 21:22

Chris · Accepted Answer · 2022-02-23 21:25:18Z

1

It appears you've essentially typoed.

    for (int index = 1; index < rainFall.length; index++) {
        if (rainFall[index] > high)
            high = rainFall[index];
            highIndex = index + 1;
    }

Your indentation suggests highIndex = index + 1; should only be executed if the condition is true, but because you don't use braces, this condition is executed on every iteration through the loop.

Perhaps you meant to write:

    for (int index = 1; index < rainFall.length; index++) {
        if (rainFall[index] > high) {
            high = rainFall[index];
            highIndex = index + 1;
        }
    }

Indentation is very useful to human beings reading your code, but it means nothing to the machine in Java.

You also likely meant to start at the beginning of the array, which is index 0.

    for (int index = 0; index < rainFall.length; index++) {
        if (rainFall[index] > high) {
            high = rainFall[index];
            highIndex = index + 1;
        }
    }

answered Feb 23, 2022 at 21:25

Chris

38.2k6 gold badges33 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

LaddieMawery Over a year ago

Thank you! I was trying to follow an example our teacher did quickly in class (to not give us a true answer). Thank you for the explanation as well!

Collectives™ on Stack Overflow

Java array: Finding index always returns the highest

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related