String is not equal to string?

Question

String[] letters  = {"A", "B", "C", "D", "E", "F", "G", "H", "I", "L"};

Scanner inp = new Scanner(System.in);
String input = (inp.nextLine());
String[] cord = input.split("");

for(int x = 0; x < 10; x++)
    if(letters[x] == cord[1])
        System.out.println("Fk yeah!");

Why the Fk yeah! never happens if I input one of A-L letters?

Are you sure cord is actually just the letter and no whitespace? — user195488
– user195488, Commented Aug 20, 2011 at 0:43
possible duplicate of What is the difference between .Equals and == — Michael Petrotta
– Michael Petrotta, Commented Aug 20, 2011 at 0:50

BalusC · Accepted Answer · 2011-08-20 00:44:34Z

24

Strings are objects. The == compares objects by reference, not by their internal value.

There are 2 solutions:

Use String#equals() method instead to compare the value of two String objects.
```
if (letters[x].equals(cord[1]))
```

Use char instead of String. It's a primitive, so == will work.

char[] letters  = {'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'L'};

Scanner inp = new Scanner(System.in);
String input = (inp.nextLine());
char[] cord = input.toCharArray();

for (int x = 0; x < 10; x++)
    if (letters[x] == cord[1])
        System.out.println("Fk yeah!");

answered Aug 20, 2011 at 0:44

BalusC

1.1m377 gold badges3.7k silver badges3.6k bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

user195488 Over a year ago

holy cow you have a lot of badges

BalusC Over a year ago

@Code: It's nothing when compared to Jon Skeet.

user195488 Over a year ago

well congrats either way :) I bow to you Sir

Paul Bellora Over a year ago

@BalusC - does the # notation in String#equals() mean its an instance method?

BalusC Over a year ago

@Kublai: Nothing special. I tend much to use javadoc style to refer the classname/methodname in written text (as one would normally do in javadocs).

user195488 · Accepted Answer · 2011-08-20 00:46:03Z

11

To compare Strings for equality, don't use ==. The == operator checks to see if two objects are exactly the same object. Two strings may be different objects, but have the same value (have exactly the same characters in them). Use the .equals() method to compare strings for equality. Similarly, use the .compareTo() method to test for unequal comparisons. For example,

String s = "something", t = "maybe something else";
if (s == t)      // Legal, but usually WRONG.
if (s.equals(t)) // RIGHT
if (s > t)    // ILLEGAL
if (s.compareTo(t) > 0) // CORRECT>

answered Aug 20, 2011 at 0:46

user195488

Collectives™ on Stack Overflow

String is not equal to string?

2 Answers 2

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related