Nested for loop through json object array does not work

Question

I need to build a new array based on json array (Context) bellow. Unfortunately I never reach the outer Loop after passing by first run. Is there any mistake in code? How can I solve this issue?

Thank you for help.

Context:

"rfqBp": [
    {
      "rfqBpId": 1041650,
      "Contact": [
        {
          "ID": 1000014,
          "SelectedContact": true
        },
        {
          "ID": 1002411,
          "SelectedContact": true
        },
        {
          "ID": 1016727,
          "SelectedContact": true
        },
        {
          "ID": 1017452,
          "SelectedContact": true
        }
      ],
    },
    {
      "rfqBpId": 1052326,
      "Contact": [
        {
          "ID": 1016236,
          "SelectedContact": true
        },
        {
          "ID": 1019563,
          "SelectedContact": true
        }
      ],
    },
    {
      "rfqBpId": 1056632,
      "Contact": [
        {
          "ID": -1,
          "SelectedContact": false
        }
      ],
    },
    {
      "rfqBpId": 1056637,
      "Contact": [
        {
          "ID": 1019875,
          "SelectedContact": true
        }
      ],
    }
  ],

script:

$scope.SelectedContacts = function() { //function starts by click on checkbox in html
  let selectedContactList = [];
  let finalList = [];
  $scope.Context.Output = [];
  for (let i = 0; i <= $scope.Context.rfqBp.length; i++) {
    for (let j = 0; j <= $scope.Context.rfqBp[i].Contact.length; j++) {
      if ($scope.Context.rfqBp[i].Contact[j].SelectedContact === true) {
        selectedContactList = {
          "ID": $scope.Context.rfqBp[i].Contact[j].ID
        };
        finalList.push(selectedContactList);

      } else if ($scope.Context.rfqBp[i].Contact[j].SelectedContact !== true) {
        continue;
      }
      $scope.Context.Output = finalList; //Output works but just for rfqBp[1]
    };
  };
  $scope.Context.Output = finalList; //this part never reached
};

Output:

  "Output": [
    {
      "ID": 1000014
    },
    {
      "ID": 1016727
    },
    {
      "ID": 1017452
    }
  ]

I try to get following:

  "Output": [
    {
      "ID": 1000014
    },
    {
      "ID": 1016727
    },
    {
      "ID": 1017452
    },
    {
      "ID": 1016236
    },
    {
      "ID": 1019563
    },
    {
      "ID": 1019875
    }
  ]

The only way you could not get to that statement is if there's an error that stops the loops. Is there any error message in the console? — Barmar
– Barmar, Commented May 6, 2022 at 8:27
Hi! Please update your question with a minimal reproducible example demonstrating the problem, ideally a runnable one using Stack Snippets (the [<>] toolbar button); here's how to do one. Your various "before" structures start in the middle of something, which makes it very hard to help you. — T.J. Crowder
– T.J. Crowder, Commented May 6, 2022 at 8:27
JSON is a textual notation for data exchange. (More here.) If you're dealing with JavaScript source code, and not dealing with a string, you're not dealing with JSON. — T.J. Crowder
– T.J. Crowder, Commented May 6, 2022 at 8:27
you are overwriting $scope.Context.Output = finalList; each iteration — john Smith
– john Smith, Commented May 6, 2022 at 8:28
<= should be <. You're accessing outside the array and getting an error. — Barmar
– Barmar, Commented May 6, 2022 at 8:34

Yosvel Quintero · Accepted Answer · 2022-05-07 05:08:28Z

1

You can use Array.prototype.flatMap() combined with Array.prototype.filter(), Array.prototype.map() and Destructuring assignment:

const rfqBp = [{rfqBpId: 1041650,Contact: [{ID: 1000014,SelectedContact: true,},{ID: 1002411,SelectedContact: true,},{ID: 1016727,SelectedContact: true,},{ID: 1017452,SelectedContact: true,},],},{rfqBpId: 1052326,Contact: [{ID: 1016236,SelectedContact: true,},{ID: 1019563,SelectedContact: true,},],},{rfqBpId: 1056632,Contact: [{ID: -1,SelectedContact: false,},],},{rfqBpId: 1056637,Contact: [{ID: 1019875,SelectedContact: true,},],},]

const result = rfqBp
  .flatMap(({ Contact }) => Contact
    .filter(({ ID }) => ID > 0) // Filter to exclude negative `ID`s
    .map(({ ID }) => ({ ID }))
  )

console.log(result)

edited May 7, 2022 at 5:08

answered May 6, 2022 at 9:07

Yosvel Quintero

19.1k5 gold badges39 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Nested for loop through json object array does not work

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related