Why does the sort() method does't work as expected with an array of strings?

Question

I'm experimenting with the sort() method in JavaScript. The documentation says the return value should be > 0 to sort b before a. I have the following code to reverse an array of strings, and have the return value as a positive integer, which I think should sort the array in the reverse order:

let nums = ["x", "y", "z"];
nums.sort((a, b) => 1); // returning a positive number to sort b before a
console.log(nums)

However, when I execute the code, the output is:

[ 'x', 'y', 'z' ] // not reversed at all

But the code does give me the expected value - [ 'z', 'y', 'x' ] - when I set the return value to a negative number. Is there an explanation for this? Am I doing something wrong?

How do you know what a and b are? You’re not even looking at them. — deceze
– deceze ♦, Commented May 8, 2022 at 5:27

MORÈ · Accepted Answer · 2022-05-08 05:28:58Z

2

Here you are not conditionally check out a and b which is greater or lesser. Returning 1 will evaluate first parameter from sort((a, b) is greater. Which returns you exact same array.

You better compare those to value inside sort callback function and depending on value return 1 or -1.

This will result ascending order.

let nums = ["x", "y", "z"];
nums.sort((a, b) => a > b ? 1 : -1);
console.log(nums)

Toggle return value to get descending order.

let nums = ["x", "y", "z"];
nums.sort((a, b) => a > b ? -1 : 1);
console.log(nums)

answered May 8, 2022 at 5:28

MORÈ

2,5823 gold badges20 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Cesare Polonara · Accepted Answer · 2022-05-08 09:24:25Z

0

That happens because the callback of sort method, takes two params but they do not correspond as one would think to first second third...etc... elements but on the contrary, a is the second element, b is the first one, so when it says that a number greater than 1 places b ahead of a that's what it does:

const nums = ['x', 'y', 'z'];

nums.sort((a, b) => {
  console.log(a,b)  // yx -zy
});

answered May 8, 2022 at 9:24

Cesare Polonara

3,9681 gold badge13 silver badges23 bronze badges

Collectives™ on Stack Overflow

Why does the sort() method does't work as expected with an array of strings?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related