php if condition

Question

I can't find anything wrong with this... This should work right?

function ConfirmedNumber()
{
$rs = mysql_query("CALL ConfirmedNumber('" , $_SESSION['UserID'] . "',@Active)");
    while ($row = mysql_fetch_assoc($rs))
    {
        if ($row['Active'] = 1)
        {
        return true;
        }
    }
return false;
}

Assuming the Stored procedure returns a single row with the value '1' in it then I can call the function like this right?

if (ConfirmedNumber())
{
//do some stuff.
}

yep, $row['Active'] = 1 will always be true, since he can assign 1 to $row['Active'], therefore return true. — Book Of Zeus
– Book Of Zeus, Commented Aug 29, 2011 at 1:47

Community · Accepted Answer · 2017-05-23 12:26:54Z

2

To expand on my comment:

if ($row['Active'] = 1) should be if ($row['Active'] == 1) to work correctly.

If you want to avoid accidentally doing this in future, you could write your if statements like this:

if (1 == $row['Active'])

This way, you can't accidentally use = as PHP will throw a Fatal Error. You can read more about Comparison Operators at PHP.net

Comment below with the full answer:

The call to the stored proc... line $rs = mysql_query("CALL ConfirmedNumber('" . $_SESSION['UserID'] . "',@Active)"); had a comma instead of the period in the initial post.

edited May 23, 2017 at 12:26

CommunityBot

11 silver badge

answered Aug 29, 2011 at 1:51

adlawson

6,4291 gold badge37 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

zerkms Over a year ago

What type do all the fields retrieved from mysql have?

Kulingar Over a year ago

@adlawson This still isn't working for some reason. Could it be that my function call is bad?

adlawson Over a year ago

@kulingar If you have a row in which 'Active' == 1, then everything looks ok, but without seeing a data dump it's difficult to tell why. The function call is perfectly fine.

Kulingar Over a year ago

@adlawson I run the stored procedure and come up with one result, column exactly titled "Active" and 1 in the cell (I personally hate how MySQL changes boolean to a tinyint with a length of 1). I'm exceptionally new to MySQL and PHP. I'm going to look into this data dump to see what's up. Will post with response. Thanks.

Phil Over a year ago

+1 for Yoda conditions!

|

Adam Fowler · Accepted Answer · 2011-08-29 01:51:01Z

1

you forgot your operator in your IF statement. Change it to this:

if ($row['Active'] == 1)

or even shorter

if ($row['Active'])

answered Aug 29, 2011 at 1:51

Adam Fowler

1,7511 gold badge17 silver badges19 bronze badges

1 Comment

Kulingar Over a year ago

The equivalence operator is making no difference. Is my call to the function correct? Or are you referring to the if statement that calls the funciton? hrm.

Marco · Accepted Answer · 2011-08-29 01:52:34Z

0

it can be something like this

    function ConfirmedNumber($id)
    {
    $rs = mysql_query("CALL ConfirmedNumber('" . $id . "',@Active)");
        while ($row = mysql_fetch_assoc($rs))
        {
            if ($row['Active'] == 1)
            {
            return true;
            }
        }
    return false;
    }
ConfirmedNumber($_SESSION['UserID']);

answered Aug 29, 2011 at 1:52

Marco

8876 gold badges21 silver badges46 bronze badges

2 Comments

Kulingar Over a year ago

No need to waste the bandwidth passing the session variable to the function. Might as well call it inside the function. Plus this isn't what my problem was. :(

Marco Over a year ago

the condition must be like that $row['Active'] == 1

Collectives™ on Stack Overflow

php if condition

3 Answers 3

6 Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related