Insert 1 value in 2d array in javascript

Question

I need some help with my code. I try to insert only one value in each array. I need to fill in the row first and after that, if the row is full then move to the next column. I try to solve this part for a couple of days but I fail. So here is my code

const testData = [1,2,3,4,5,6,7,8,9];                
const create2dArray = (row, column) => {
                    var result = [];
                    for(let i = 0; i< row; i++){
                        result[i]= [];
                        for(let j = 0; j<column; j++){   
                            result[i][j] = [];
                            for(let e = 0; e < testData.length; e++){
                            result[i][j] = [testData[e]];
                            }
                        }
                    }
                    return result;
            
                }
            let Column = 5
            let Row = 5
            filterQuotaData(EnrollmentQuota);
            var ground = create2dArray(Column,Row);
            console.log(ground);

Suppose the output is :

[1],[2],[3],[4],[5]
[6],[7],[8],[9],[]
[],[],[],[],[]
[],[],[],[],[]
[],[],[],[],[]

instead, I got:

[9],[9],[9],[9],[9]
[9],[9],[9],[9],[9]
[9],[9],[9],[9],[9]
[9],[9],[9],[9],[9]
[9],[9],[9],[9],[9]

I hope someone can help me to solve this problem

dudung · Accepted Answer · 2022-05-22 11:45:05Z

1

Following code

const testData = [1,2,3,4,5,6,7,8,9];                
const create2dArray = (row, column) => {
                    var result = [];
                    k = 0
                    for(let i = 0; i< row; i++){
                        result[i]= [];
                        for(let j = 0; j<column; j++){   
                            if(k < testData.length) {
                              result[i][j] = [testData[k]];
                            } else {
                              result[i][j] = [];
                            }
                            k++
                        }
                    }
                    return result;
            
                }
            let Column = 5
            let Row = 5
            //filterQuotaData(EnrollmentQuota);
            var ground = create2dArray(Column,Row);
            console.log(ground);

produces

[
  [ [ 1 ], [ 2 ], [ 3 ], [ 4 ], [ 5 ] ],
  [ [ 6 ], [ 7 ], [ 8 ], [ 9 ], [] ],
  [ [], [], [], [], [] ],
  [ [], [], [], [], [] ],
  [ [], [], [], [], [] ]
]

Does it what you need?

answered May 22, 2022 at 11:45

dudung

7891 gold badge7 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

NetSkylz Over a year ago

You can improve a bit this answer by replacing the "k" length check with this shorter syntax: const data = testData[k]; result[i][j] = data ? [data] : [];

newbies Over a year ago

yes, that is what I want to do, thank you solve my problem, I really appreciate it

newbies Over a year ago

How to random the output in the array?

dudung Over a year ago

Do you mean the put values of testData in random order in the output? Or generate random values in testData?

zer00ne · Accepted Answer · 2022-05-22 12:42:23Z

0

What's happening in your code is that you have the 3rd loop adding everything to each column from 2nd loop. The reason why they are all 9s is because you are overwriting each column by using an assignment instead of adding it to the array:

// 3rd loop
array[0][0][0] = 1 // 1st iteration [[[1],...]]
array[0][0][1] = 2 // 2nd iteration [[[2],...]]

Here's an example that uses 2 loops and pushes sub-arrays and shifts from test array.

const test = [1, 2, 3, 4, 5, 6, 7, 8, 9];
const create2dArray = (row, column) => {
  let result = [];
  for (let r = 0; r < row; r++) {
    result.push([]);
    for (let c = 0; c < column; c++) {
      let data = test.length < 1 ? [] : [test.shift()]
      result[r].push(data);
    }
  }
  return result;
}
let row = 5, col = 5;

let ground = create2dArray(row, col);
console.log(JSON.stringify(ground));

edited May 22, 2022 at 12:42

answered May 22, 2022 at 12:32

zer00ne

45.2k6 gold badges50 silver badges82 bronze badges

1 Comment

newbies Over a year ago

Thank you very much, I really appreciate it. Good explanation, really helps me to understand my issues with my code. Have a great day man

Collectives™ on Stack Overflow

Insert 1 value in 2d array in javascript

2 Answers 2

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related