find max Consecutive Ones in array using javascript

Question

I have an array of numbers. I need to find the maximum number of consecutive 1s in the array.

var arr = [1, 1, 3, 2, 3, 1, 1, 1];

const maxOne = (arr) => {
  for (var i = 0; i < arr.length; i++) {
    let count = 0;
    let result = 0;
    if (arr[i] ==1) {
      count += 1;
      result = Math.max(result, count);
    } else {
      count = 0
    }
  return result
  }
}

console.log(maxOne(arr));

desired output: 3

my output : 1

I am not sure where I am going wrong

Your code re-initializes result for each array element. It should not do that. — Pointy
– Pointy, Commented Jun 4, 2022 at 13:57
maximum number of consecutive .. and yet 3 is never consecutive from your input sample of arr? — mardubbles
– mardubbles, Commented Jun 4, 2022 at 13:57
@mardubbles there are three 1 values at the end of the array? — Pointy
– Pointy, Commented Jun 4, 2022 at 13:58
Also, the function should probably return result instead of print it. — 001
– 001, Commented Jun 4, 2022 at 14:00

Mero · Accepted Answer · 2022-06-04 14:12:04Z

1

You algorithm works, you just did few misstakes:

create variables outside of loop
return after loop, not in it(it will break loop at first iteration)

const maxOne = (arr) => {
  let count = 0;
  let result = 0;
  for (var i = 0; i < arr.length; i++) {
    if (arr[i] === 1) {
      count += 1;
      result = Math.max(result, count);
    } else {
      count = 0
    }
  }
  return result
}

answered Jun 4, 2022 at 14:12

Mero

7739 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Karan soni · Accepted Answer · 2022-06-04 14:40:53Z

0

You can do like this.

let arr=[1,2,3,1,1,2,1,1,12,1,1,1,1];
let count=0;
for(let i=0;i<arr.length;i++){
  arr[i]==1 ? count+=1 :count=0;
}
console.log(count).

edited Jun 4, 2022 at 14:40

answered Jun 4, 2022 at 14:36

Karan soni

13 bronze badges

2 Comments

Gustavo Sousa Over a year ago

The . character at the end of the last line should be a ;, making it: console.log(count);.

Karan soni Over a year ago

That was just a typo @GustavoSousa

mehrnaz nazari · Accepted Answer · 2023-01-31 12:29:04Z

0

const numbers = [1,1,0,0,1,1,1,0,1];
const maxString = Math.max(...numbers.join('').split('0')); // remove zero items and convert 
// the sequential Ones to a string. After that Find the string with the largest number of characters.
console.log('max:', maxString.toString().length) // Take the string length
//3

you can use *Math.max.apply(Math, numbers.join('').split('0'))* instead of second line.

answered Jan 31, 2023 at 12:29

mehrnaz nazari

134 bronze badges

Collectives™ on Stack Overflow

find max Consecutive Ones in array using javascript

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related