JQuery problems with setting variables in if/else

Question

I'm trying to set a variable to 0 if an item attribute is equal a specific string, else set the variable to 1, but I can't get it to work.

My code is like this in my javascript function:

    var variable;
    if ($(this).attr("attribute", "string"))
        variable=0;
    else
        variable=1;

For some reason, the variable always get set to 0, even if the item attribute isn't equal the specific string.

What am I doing wrong??

see api.jquery.com/attr

Peter
– Peter

2011-09-01 11:39:26 +00:00
Commented Sep 1, 2011 at 11:39 — Peter
– Peter, Commented Sep 1, 2011 at 11:39

Arnaud Le Blanc · Accepted Answer · 2011-09-01 11:36:54Z

3

You have to use this instead:

var variable;
if ($(this).attr("attribute") == "string")
    variable=0;
else
    variable=1;

$(this).attr("attribute", "string") sets the attribute attribute to string, it doesn't test if attribute equals string.

See the attr(attributeName,value) method documentation.

answered Sep 1, 2011 at 11:36

Arnaud Le Blanc

100k24 gold badges211 silver badges196 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ipr101 · Accepted Answer · 2011-09-01 11:37:08Z

1

Try -

var variable;
if ($(this).attr("attribute") == "string")
    variable=0;
else
    variable=1;

This compares the value of attribute "attribute" to the value "string". What you're doing at the moment is setting the value of attribute "attribute" to the value "string". I suspect this function will return a "truthy" value hence variable always being set to 0.

answered Sep 1, 2011 at 11:37

ipr101

24.2k8 gold badges61 silver badges62 bronze badges

Comments

epascarello · Accepted Answer · 2011-09-01 11:38:00Z

1

You are setting the string in your if

if( $(this).attr("attribute", "string") ){

You need to read it and compatre

if( $(this).attr("attribute") === "string") ){

answered Sep 1, 2011 at 11:38

epascarello

208k20 gold badges206 silver badges246 bronze badges

Comments

Tom · Accepted Answer · 2011-09-01 11:38:51Z

0

Try $(this[attribute="string"]).

answered Sep 1, 2011 at 11:38

Tom

2694 silver badges14 bronze badges

Collectives™ on Stack Overflow

JQuery problems with setting variables in if/else

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related