Unable to pass/exit a python function

Question

Just starting out with python functions (fun_movies in functions.py) and I can't seem to get out (via "no" or False) once in the loop:

main_menu.py

from functions import *

def menu():
   print("Press 1 for movies.")
   print("Press 2 to exit.")
menu()

option = int(input("Input a number: "))

while option != 0:
#try:
   if option == 1:
       fun_movies()
   elif option == 2:
       print("Goodbye! ")
       break
   else:
       print ("Wrong input")

functions.py

global movies
movies = {}

def fun_movies():
   name = input("Insert movie name: ")
   genre = input("Input genre: ")
   movies [name] = [genre]

   a = True
   while a:
       query = input("Do you want to input another movie? (yes/no) ")
       if query == "yes":
           name = input("Insert movie name: ")
           genre = input("Input genre: ")
           movies_if = {}
           movies_if [name] = [genre]
           movies.update(movies_if)
       elif query == "no":
           break
       else:
           print ("Wrong input!")        
   return movies

Code works fine when not called via import. When called via import (in main_menu.py), it keeps asking for infinite movies even when I input a "no". I can't find a way to exit the loop. Initially I had a "pass" but that didn't work.

Thanks in advance!

In the else case you aren't checking the result before the next time the user is prompted for input. So you're ignoring the input to half the prompts (the ones in the else , but not the ones at the top of the loop). — Charles Duffy
– Charles Duffy, Commented Jul 3, 2022 at 17:00
Please update your question with the correctly formatted code. — quamrana
– quamrana, Commented Jul 3, 2022 at 17:01
Have you considered just deleting the second assignment to query, to leave only the one whose result is correctly processed? — Charles Duffy
– Charles Duffy, Commented Jul 3, 2022 at 17:01
Also, consider adding repl(query) to what you print in the "Wrong input!" message. — Charles Duffy
– Charles Duffy, Commented Jul 3, 2022 at 17:02
To get out of a loop you can use break to skip an iteration you can use continueszzs — Nesi
– Nesi, Commented Jul 3, 2022 at 17:05

Game Developement · Accepted Answer · 2022-07-04 16:44:31Z

1

global movies
movies = {}

def fun_movies():
    name = input("Insert movie name: ")
    genre = input("Input genre: ")


    movies [name] = [genre]

    a = True
    while a:
        query = input("Do you want to input another movie? (yes/no) ")
        if query == "yes":
            name = input("Insert movie name: ")
            genre = input("Input genre: ")
            movies_if = {}
            movies_if [name] = [genre]
            movies.update(movies_if)
        elif query == "no":
            a = False
        else:
            print ("Wrong input!")        
    return movies

A few things:

Firstly, you don't need a==True as this statement returns True when a is True and False when a is False, so we can just use a as the condition.

Secondly, only use the input at the start of the loop as you want to ask once per iteration

Thirdly, place your return outside the loop so you only return when a==False and you don't want to input another movie.

edit: main file>

from functions import *

def menu():
   print("Press 1 for movies.")
   print("Press 2 to exit.")
menu()

option = int(input("Input a number: "))

while option != 0:
   if option == 1:
       fun_movies()
   elif option == 2:
       print("Goodbye! ")
       break
   else:
       print ("Wrong input")
   option = int(input("Input a number"))

edited Jul 4, 2022 at 16:44

answered Jul 3, 2022 at 17:09

Game Developement

4092 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

from stackoverflow import all Over a year ago

Thanks for your time, however when I call the function from another file it keeps asking me (even after saying "no" to insert a new movie.

Game Developement Over a year ago

@fromstackoverflowimportall can you show your other file? Maybe you're calling the function more than once, as I have tested this function and it works fine.

from stackoverflow import all Over a year ago

I have updated the code that doesn't let me exit once added a movie.

Game Developement Over a year ago

@fromstackoverflowimportall you are not adding input to the loop, see my edited post

from stackoverflow import all Over a year ago

Game Development you are right, I would only add (to your solution) menu() before the input so the end user knows what his/her options are. Thanks for your patience and solutions!

Ozan Sen · Accepted Answer · 2022-07-04 07:11:03Z

0

global movies
movies = {}

def fun_movies():
    name = input("Insert movie name: ")
    genre = input("Input genre: ")
    movies[name]= genre
    a = True
    while a:
        query = input("Do you want to input another movie?   (yes/no) ")
        if query == "yes":
            name = input("Insert movie name: ")
            genre = input("Input genre: ")
            movies_if = {}
            movies_if [name] = genre
            movies.update(movies_if)       
        elif query == "no":
            break
              
        else:
            print ("Wrong input!")
            # continue
    return movies

print(fun_movies())

Hope It works for you!

answered Jul 4, 2022 at 7:11

Ozan Sen

2,6152 gold badges6 silver badges20 bronze badges

2 Comments

from stackoverflow import all Over a year ago

Thanks for your time, I tried a break previously too, but when I call the function (fun_movies()) from another file (from functions import *) it keeps asking me (even after saying "no" to insert a new movie.

Chris Over a year ago

Welcome to Stack Overflow. Code is a lot more helpful when it is accompanied by an explanation. Stack Overflow is about learning, not providing snippets to blindly copy and paste. Please edit your answer and explain how it answers the specific question being asked. See How to Answer.

Collectives™ on Stack Overflow

Unable to pass/exit a python function

2 Answers 2

5 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related