link_to breaking javascript when calling from javascript in rails?

Question

I have a form that posts a 'thought'. I have it set up to do this using ajax. It basically just appends the thought and the user who posted the thought to the end of the list of thoughts. This worksas expected using this javascript in create.js.erb

$('#thoughts')
  .append("<div class='thoughts'><%= @thought.user.name %><p><%= @thought %></p></div>");

but when i try to add a link to the user who posted the thought like so

$('#thoughts')
  .append("<div class='thoughts'><%= link_to(@thought.user.name, @thought.user) %><p><%= @thought %></p></div>");

it does append the thought to the list of thoughts. It still posts it to the database but it doesn't display it.

Any help will be much appreciated, thank you.

Mischa · Accepted Answer · 2011-09-04 01:22:26Z

3

You have to use escape_javascript like this:

$('#thoughts')
  .append("<div class='thoughts'><%= escape_javascript(link_to(@thought.user.name, @thought.user)) %><p><%= @thought %></p></div>");

If you don't use escape_javascript create.js.erb will generate the following code, which does not work for obvious reasons:

$('#thoughts')
  .append("<div class='thoughts'><a href="/thoughts/1">Username</a><p>Thought</p></div>");
                                       # ^
                                       # This is the problem,
                                       # which is fixed by escape_javascript

edited Sep 4, 2011 at 1:22

answered Sep 4, 2011 at 1:15

Mischa

43.4k9 gold badges101 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

link_to breaking javascript when calling from javascript in rails?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related