Delete row from table and sqlite database

Question

I have some problem deleting rows from a database and table.

The problem is: I can swipe the row, tap the "delete" button, but nothing happens.

Probably i'm doing it wrong.

Can Somebody give me a tip? Here there is all the program if you want to take a look:(updated)

-(void)tableView:(UITableView *)_tableView commitEditingStyle:(UITableViewCellEditingStyle)editingStyle forRowAtIndexPath:(NSIndexPath *)indexPath {

    if (editingStyle == UITableViewCellEditingStyleDelete) {

    NSDictionary *rowVals = (NSDictionary *) [shoppingListItems objectAtIndex:indexPath.row];
    NSString *keyValue = (NSString *) [rowVals objectForKey:@"key"];

    [_tableView beginUpdates];
    [_tableView deleteRowsAtIndexPaths:[NSArray arrayWithObject:indexPath] withRowAnimation:UITableViewRowAnimationFade];
    //Here i got the SIGABRT error
    [_tableView endUpdates];

    sqlite3 *db;
    int dbrc; //Codice di ritorno del database (database return code)
    DatabaseShoppingListAppDelegate *appDelegate = (DatabaseShoppingListAppDelegate*) [UIApplication sharedApplication].delegate;
    const char *dbFilePathUTF8 = [appDelegate.dbFilePath UTF8String];
    dbrc = sqlite3_open(dbFilePathUTF8, &db);
    if (dbrc) {
        NSLog(@"Impossibile aprire il Database!");
        return;
    }

    sqlite3_stmt *dbps; //Istruzione di preparazione del database

    NSString *deleteStatementsNS = [NSString stringWithFormat: @"DELETE FROM \"shoppinglist\" WHERE key='%@'", keyValue];

    const char *deleteStatement = [deleteStatementsNS UTF8String];
    dbrc = sqlite3_prepare_v2(db, deleteStatement, -1, &dbps, NULL);
    dbrc = sqlite3_step(dbps);


    //faccio pulizia rilasciando i database
    sqlite3_finalize(dbps);
    sqlite3_close(db);

}
}

#

Thanks to Akshay, finally i fixed this portion of code. I write here the solution for the ones who'll need it.

-(void)tableView:(UITableView *)_tableView commitEditingStyle:(UITableViewCellEditingStyle)editingStyle forRowAtIndexPath:(NSIndexPath *)indexPath {

if (editingStyle == UITableViewCellEditingStyleDelete) {

    NSDictionary *rowVals = (NSDictionary *) [shoppingListItems objectAtIndex:indexPath.row];
    NSString *keyValue = (NSString *) [rowVals objectForKey:@"key"];

    [tableView beginUpdates];

    sqlite3 *db;
    int dbrc; //Codice di ritorno del database (database return code)
    DatabaseShoppingListAppDelegate *appDelegate = (DatabaseShoppingListAppDelegate*) [UIApplication sharedApplication].delegate;
    const char *dbFilePathUTF8 = [appDelegate.dbFilePath UTF8String];
    dbrc = sqlite3_open(dbFilePathUTF8, &db);
    if (dbrc) {
        NSLog(@"Impossibile aprire il Database!");
        return;
    }

    sqlite3_stmt *dbps; //Istruzione di preparazione del database

    NSString *deleteStatementsNS = [NSString stringWithFormat: @"DELETE FROM \"shoppinglist\" WHERE key='%@'", keyValue];

    const char *deleteStatement = [deleteStatementsNS UTF8String];
    dbrc = sqlite3_prepare_v2(db, deleteStatement, -1, &dbps, NULL);
    dbrc = sqlite3_step(dbps);


    //faccio pulizia rilasciando i database
    sqlite3_finalize(dbps);
    sqlite3_close(db);

    [tableView deleteRowsAtIndexPaths:[NSArray arrayWithObject:indexPath] withRowAnimation:UITableViewRowAnimationFade];
    [shoppingListItems removeObjectAtIndex:indexPath.row];

    [tableView endUpdates];

    [tableView reloadData];
}
}

@Oiproks When asking a questions, please always tell us whether you have an error of some sorts, or you have an unexpected behavior and what the expected behavior is (which happens to be obvious in this case, but may not be obvious in general case). — Branko Dimitrijevic
– Branko Dimitrijevic, Commented Sep 4, 2011 at 10:27
@Oiproks Sorry for the interruption,my code is getting crashed at line NSString *keyValue = (NSString *) [rowVals objectForKey:@"key"];Please help me — Eshwar Chaitanya
– Eshwar Chaitanya, Commented Jan 9, 2012 at 12:00

Akshay · Accepted Answer · 2013-03-05 22:53:00Z

2

You should be calling:

[tableView beginUpdates];
[tableView deleteRowsAtIndexPaths:[NSArray arrayWithObject:indexPath]
        withRowAnimation:UITableViewRowAnimationFade];
[tableView endUpdates];

inside commitEditingStyle: instead of reloadData. Also, make sure that you delete the entity from the DB & return one less from numberOfRowsInSection:.

edited Mar 5, 2013 at 22:53

user142162

answered Sep 4, 2011 at 11:36

Akshay

5,7593 gold badges25 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Oiproks Over a year ago

i tried as you said, but i receive SIGABRT on "[tableView endUpdates];", and I don't know how to return one less row... :( I'm not so skilled...

Akshay Over a year ago

What do you return in numberOfRowsInSection: ? If you had 3 rows before swiping & were returning 3, now return 2.

Oiproks Over a year ago

There I return the number of items in the array shoppingListItems (return [shoppingListItems count];) charged from the db. How can I tell it to count one less?

Oiproks Over a year ago

Actually the program delete the content of the database. After i delete something, the simulator crash, i run it again, and the row is disappeared! So the problem is just in removing the row from the table!

Akshay Over a year ago

The problem is the crash. You should delete the row from the DB between beginUpdates & endUpdates. If you are returning the right number after the swipe, you should be good.

|

Nekto · Accepted Answer · 2011-09-04 10:19:25Z

1

I think the problem is in this line

NSString *insertStatementsNS = [NSString stringWithFormat: @"DELETE FROM \"shoppinglist\" WHERE key=?", indexPath];

I think you want to have in insertStatementsNS this:

NSString *insertStatementsNS = [NSString stringWithFormat: @"DELETE FROM \"shoppinglist\" WHERE key=%@", indexPath];

or

NSString *insertStatementsNS = [NSString stringWithFormat: @"DELETE FROM \"shoppinglist\" WHERE key='%@'", indexPath];

answered Sep 4, 2011 at 10:19

Nekto

17.9k1 gold badge57 silver badges65 bronze badges

4 Comments

Oiproks Over a year ago

Well.. the problem is not only there! Actually i can't see if that one is working or not cos after I swipe and delete nothing happens... probably there is something wrong somewhere else :S

Praveen-K Over a year ago

commitEditingStyle is calling ?

Oiproks Over a year ago

To read the correct value from the cell i did this.

NSDictionary *rowVals = (NSDictionary *) [shoppingListItems objectAtIndex:indexPath.row];         NSString *keyValue = (NSString *) [rowVals objectForKey:@"key"];

Then i pass the keyValue variable to the Query. I'm sure is more efficient. But I still have problem deleting the row .____. that's so annoying! If I link you the project, can you take a look? maybe is something stupid...

Oiproks Over a year ago

Something new! Actually the program delete the content of te database. After i delete something, the simulator crash, i run again, and the row is disappeared! So the problem is just in removing the row from the table!

Collectives™ on Stack Overflow

Delete row from table and sqlite database

2 Answers 2

9 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

9 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related