Acessing object through object array

Question

I want to learn classes atm and here is what I came up with:

Class level to create a level. This class has an object array that fills itself with rooms (raeume) which is the other class. Now, I want to access the objects in the object array from room, after I inserted them. Here is what I want to type:

wohnung.rooms[i].raumname.toString();

Here are the two classes

class raum
{
    static object[] o_nebenraum = new object[3]; //N-O-S-W
    static string s_raumname = "";
    public object[] nebenraume
    {
        get
        {
            return o_nebenraum;
        }
        set
        {
            o_nebenraum = value;
        }
    }
    public string raumname
    {
        get
        {
            return s_raumname;
        }
        set
        {
            s_raumname = value;
        }
    }
}

class level
{
    static object[] o_rooms = new object[100];

    public object[] rooms
    {
        get
        {
            return o_rooms; 
        }
        set
        {
            o_rooms = value;
        }
    }
}

Here is how I set everything up.

level wohnung = new level();
        raum keller = new raum();
        raum wohnzimmer = new raum();
        raum kueche = new raum();
        raum schlafzimmer = new raum();
        wohnung.rooms[0] = keller;
        wohnung.rooms[1] = wohnzimmer;
        wohnung.rooms[2] = kueche;
        wohnung.rooms[3] = schlafzimmer;
        keller.raumname = "Keller";
        wohnzimmer.raumname = "Wohnzimmer";
        kueche.raumname = "Küche";
        schlafzimmer.raumname = "Schlafzimmer";
        for (uint i = 0; i < 3; i++)
        {
            Console.WriteLine("Wohnung beinhaltet jetzt " + *MISSING CODE PART, I WANT TO GET THE .raumname out of the object array from wohnung.room*); 
        }
        Console.ReadKey();

why are s_raumname, o_nebenraum and o_rooms static? Why is o_nebenraum of type object[] instead of raum[]? Why do you use arrays instead of List? — Stephan Bauer
– Stephan Bauer, Commented Sep 6, 2011 at 13:13
You should access them anywhere, o_nebenraum is now raum[] and I also use Lists now as stated bewlow :) — Liam Schnell
– Liam Schnell, Commented Sep 6, 2011 at 13:50
if s_raumname is static, this will result in a "strange" behavior, that all rooms will have the same name (the last one that is assigned - in this case "Schlafzimmer") — Stephan Bauer
– Stephan Bauer, Commented Sep 6, 2011 at 14:00

sll · Accepted Answer · 2011-09-06 13:09:17Z

2

You have to use generic typed list List<T> (See on MSDN) instead of array, in this case you'll have the indexed access for the typed list elements

So instead of:

static object[] o_rooms = new object[100];      
public object[] rooms

Use:

static IList<raum> o_rooms = new List<Raum>(100);      
public IList<raum> rooms

answered Sep 6, 2011 at 13:09

sll

62.7k22 gold badges109 silver badges157 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chandu · Accepted Answer · 2011-09-06 14:03:28Z

1

Try this(in the for Loop):

Console.WriteLine("Wohnung beinhaltet jetzt " + (wohnung.rooms[i] as raum).raumname );

You would be better off using generics though in which case the class level would now look like:

class level 
{     
    static List<raum> o_rooms = new List<raum>();
    public List<raum> rooms
    {         
        get         {             return o_rooms;          }         
        set         {             o_rooms = value;         }     
    }
}

and the for loop can be replaced with a foreach loop as follows:

foreach(raum room in wohnung.rooms)
{
    Console.WriteLine("Wohnung beinhaltet jetzt " + room.raumname ); 
}

edited Sep 6, 2011 at 14:03

answered Sep 6, 2011 at 13:10

Chandu

83.2k19 gold badges136 silver badges136 bronze badges

2 Comments

Liam Schnell Over a year ago

Easiest method for me and 100% understandable at the moment :)

Stephan Bauer Over a year ago

if List<raum> o_rooms is static, every instance of level will have the same rooms. By the way: Your public property has no name...

Collectives™ on Stack Overflow

Acessing object through object array

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related