regex + jquery - modify text

Question

<span id="one"><a id="google" href="google.com/">link1</a></span> <br />
<span id="two"><a id="yahoo" href="yahoo.com/">link2</a></span>

<br />
<br />
<span class="click" id=1>click one</span> <br />
<span class="click" id=2>click two</span> <br />
<span class="click" id=3>click three</span> <br />

$(".click").live('click', function() {    
   $("a").attr('href', $("a").attr('href').replace(/\d*$/, $(this).attr('id')));
});

If I click for example click one then links are:

<span id="one"><a id="google" href="google.com/1">link1</a></span> <br />
<span id="two"><a id="yahoo" href="google.com/1">link2</a></span>

instead of:

<span id="one"><a id="google" href="google.com/1">link1</a></span> <br />
<span id="two"><a id="yahoo" href="yahoo.com/1">link2</a></span>

LIVE EXAMPLE: http://jsfiddle.net/wtAbp/14/

How can I fix it?

Samich · Accepted Answer · 2011-09-07 09:37:06Z

2

Here is working sample http://jsfiddle.net/wtAbp/18/

$(".click").live('click', function() {  
    var $id = $(this).attr('id');
    $("a").each(function() {
        $(this).attr('href', $(this).attr('href').replace(/\d*$/, $id));
    });
});

answered Sep 7, 2011 at 9:37

Samich

30.4k6 gold badges70 silver badges80 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dogbert · Accepted Answer · 2011-09-07 09:37:18Z

1

You're using $("a") instead of $(this)

$(".click").live('click', function() {    
   $(this).attr('href', $(this).attr('href').replace(/\d*$/, $(this).attr('id')));
});

answered Sep 7, 2011 at 9:37

Dogbert

224k43 gold badges419 silver badges416 bronze badges

Comments

Kent · Accepted Answer · 2011-09-07 09:44:42Z

1

$(".click").live('click', function() {
    var id = $(this).attr('id');
    $("a").each(function() {
        $(this).attr('href', $(this).attr('href').replace(/\d*$/, id));
    });
});

Cheer ^^

answered Sep 7, 2011 at 9:44

Kent

2,9502 gold badges27 silver badges42 bronze badges

Comments

Richard · Accepted Answer · 2011-09-07 09:44:55Z

1

The reason is that when you click one it replaces the values on all a elements. Try this:

<span id="one"><a id="google" href="google.com/">link1</a></span> <br />
<span id="two"><a id="yahoo" href="yahoo.com/">link2</a></span>

<br />
<br />
<span class="click" id=1>click one</span> <br />
<span class="click" id=2>click two</span> <br />
<span class="click" id=3>click three</span> <br />

$(".click").live('click', function() {    
    var $this = $(this);
    $.each("a", function(index, element) {
              $(element).attr('href',            $(element).attr('href').replace(/\d*$/, $this.attr('id')));
    });

});

answered Sep 7, 2011 at 9:44

Richard

22.1k13 gold badges64 silver badges102 bronze badges

Collectives™ on Stack Overflow

regex + jquery - modify text

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related