Javascript wait on async forEach loop

Question

I am creating MongoDB records based on user inputs, and then for each new object created, I am pushing the object ID into an array. My problem is my console.log statement in the last line returns empty. So How I could wait on the forEach execution to be over so I have the updated assetsArray, any help is appreciated! Here is my code:

let assetsArray = [];
if (assets) {
  JSON.parse(assets).forEach(asset => {
    Image.create({
      organization: organizationID,
      imageName: asset.imageName,
      imageDescription: asset.imageDescription ?? null,
      imagePath: asset.imagePath
    }).then(record => {
      console.log(record)
      assetsArray.push(record._id)
    })
  })
}
console.log(assetsArray)

Sridhar · Accepted Answer · 2022-09-06 02:41:41Z

2

You can use Promise.all for your case

const tasks = JSON.parse(assets).map(asset => {
  return Image.create({
    organization: organizationID,
    imageName: asset.imageName,
    imageDescription: asset.imageDescription ?? null,
    imagePath: asset.imagePath,
  })
});

Promise.all(tasks).then((records) => {
  return records.map(record => {
    console.log(record)
    return record._id
  })
}).then(assetsArray => {
  console.log(assetsArray)
})

edited Sep 6, 2022 at 2:41

Sridhar

11.8k5 gold badges42 silver badges48 bronze badges

answered Sep 6, 2022 at 2:21

An Nguyen

3001 silver badge6 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

An Nguyen Over a year ago

Let me update the code snippet

An Nguyen Over a year ago

Updated @Jacky.S

An Nguyen Over a year ago

Thanks @hackape for your contribution.

Jacky.S Over a year ago

My new question is how would I able to use assetsArray outside the .then() function. For example, after that code block, I am creating a new MongoDB object, that needs the assetsArray to be filled first

An Nguyen Over a year ago

const records = await Promise.all(tasks); const recordIds = records.map(record => record._id);

|

Collectives™ on Stack Overflow

Javascript wait on async forEach loop

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related