Empty array after filter that shouldn't be empty

Question

This is my function

const filterPerBlocked = (showBlocked) => {
        const filtered_copy = [];
        filtered.forEach( (element) => {
            let composites_copy = element.composites.filter( (composite) => {
                composite.blocked == showBlocked
            })
            
            filtered_copy.push({
                category: _.cloneDeep(element.category),
                composites: composites_copy
            })
        });

        console.log(filtered_copy);
    }

Some elements inside the filter are giving true result on composite.blocked == showBlocked but composites_copy its always empty, shouldn't composites_copy contain the filtered result?

I thought that the return was implicit if the function has only one line — fg_st
– fg_st, Commented Sep 22, 2022 at 14:52
As stated above using .filter() requires you to return true or a true-ty value for the items you want to keep. Since you do not return anything inside the filter function, your array always ends up empty. And you are not using a one-liner arrow function, since you use braces around the function body. => { }. So try composite => composite.blocked === showBlocked without braces. — Shilly
– Shilly, Commented Sep 22, 2022 at 14:53
@fg_st, it would be implicit if you surround it with parenthesis , (composite) => (composite.blocked == showBlocked) — Paridokht
– Paridokht, Commented Sep 22, 2022 at 14:54

some-user · Accepted Answer · 2022-09-22 14:54:02Z

2

Your filter function is not returning anything. You should either add a return:

let composites_copy = element.composites.filter( (composite) => {
   return composite.blocked == showBlocked
})

or simplify to:

let composites_copy = element.composites.filter( 
  (composite) => composite.blocked == showBlocked
)

answered Sep 22, 2022 at 14:54

some-user

5,0306 gold badges26 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Empty array after filter that shouldn't be empty

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related