powershell IF condition in a Variable

Question

I've been strugling on a little thing for few hours now, and I wanted to know if one of you have the solution (maybe i'm missing a little thing)

I got a switch for setting the condition in a IF but seems it doesn't interprete it as a if condiction

switch ( $CampaignStatus )
{
    "Complete"   { $CampainCondition = ($DateStr -eq (get-date  -Format "MM/dd/yyyy"))   }
    "Incomplete" { $CampainCondition =  ($DateStr -eq (get-date  -Format "MM/dd/yyyy"))   }
    "InProgress" { $CampainCondition =  ($DateStr -gt (get-date  -Format "MM/dd/yyyy"))   }
}

foreach($c in $CampaignList) {  
 $index = $index +1

    $DateStr = ConvertToFriendlyDate -Date $c.deadline
    if ($CampainCondition) { blablabla}

Any idea ?

I tried with quotes, without etc

$DateStr -gt (get-date -Format "MM/dd/yyyy") won't work correctly. For comparing dates in string format, the year must come first. — zett42
– zett42, Commented Nov 10, 2022 at 15:47
It's a bit odd that you're comparing two of the same conditions as well. Complete, and Incomplete will return the same value. So, you really only need one. Another odd thing is your switch statement seems to be before your assignment of $DateStr, yet you are using that result to compare inside your switch. Can you elaborate more on that? — Abraham Zinala
– Abraham Zinala, Commented Nov 10, 2022 at 15:49
@AbrahamZinala Yeah, but there is another switch which will pass in param another array, it's the same condition for different array and values — Valden
– Valden, Commented Nov 10, 2022 at 16:02

Santiago Squarzon · Accepted Answer · 2022-11-10 15:50:12Z

4

You're looking for Script Blocks to store those expressions and later evaluate them:

$CampainCondition = switch ( $CampaignStatus ) {
    "Complete"   { { $DateStr -eq (Get-Date -Format "MM/dd/yyyy") } }
    "Incomplete" { { $DateStr -eq (Get-Date -Format "MM/dd/yyyy") } }
    "InProgress" { { $DateStr -gt (Get-Date -Format "MM/dd/yyyy") } }
}

Then for evaluation, you can use the call operator &:

foreach($c in $CampaignList) {
    $index   = $index++
    $DateStr = ConvertToFriendlyDate -Date $c.deadline
    if(& $CampainCondition) {
        <# blablabla #>
    }
    <# blablabla #>
}

As for the conditions themselves, instead of converting the date into a specific format (Get-Date -Format "MM/dd/yyyy") and then comparing that string with $DateStr, it would a much better idea to parse $DateStr as a DateTime instance and compare that against today's date.

edited Nov 10, 2022 at 15:50

answered Nov 10, 2022 at 15:45

Santiago Squarzon

65.6k5 gold badges26 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mathias R. Jessen Over a year ago

-gt is not gonna work as expected on mixed-endian date formats

Santiago Squarzon Over a year ago

@MathiasR.Jessen well I agree, I added an update regarding that, thanks

Collectives™ on Stack Overflow

powershell IF condition in a Variable

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related