Basic multiple if statement logic flow syntax in PowerShell

Question

I can't seem to understand how to continue to another IF statement. What I'm trying to do is:

IF Action 1 succeed then do X AND go to Action 2, else log it and RETURN to the next loop
If Action 2 succeed then do X AND go to Action 3, else log it and RETURN to the next loop

I am having issues with "AND go to Action 2" after action 1. I tried various ways but obviously the script below does not work. It can do Action 1 the test-connection, and if it succeeds will export the log else it will log a failure and RETURN to the next loop. HOWEVER, I cannot make it do the next action if successful.

$hostname = Import-Csv C:\Users\jackie.cheng\Desktop\TestComputers.csv

$hostname | % {

if (Test-Connection $_.hostname -count 1)

{Write-Host "$($_.hostname) Test-Connection Succeeded"
            $array += [pscustomobject]@{
                Name = $currentobject.hostname
                Status = "Test-Connection Success"}
}

else  {Write-Host "$($_.hostname) Test-Connection Failed"
            $array2 += [pscustomobject]@{
                Name = $currentobject.hostname
                Status = "Failed Test-Connection"}
       } return

if (Test-Connection $_.hostname -count 1)

{Write-Host "Second action ran"}

else {Write-Host "Second action failed"} return


}

That's just something I was doing in the catch. I had to rename $currentobject = $_. I will edit that. — DrixlRey
– DrixlRey, Commented Nov 16, 2022 at 18:59
You are thinking in a legacy VB/BAT GOTO mindset. There is no GOTO in PS, though can simulate it. There are several docs you can find on the web. You should also refresh your mindset on the Return keyword when used with PowerShell. — postanote
– postanote, Commented Nov 16, 2022 at 21:05
Both returns run every time outside of the if/else's. You usually don't need return at all. And why do two test-connections in the same loop? — js2010
– js2010, Commented Nov 17, 2022 at 17:48

emanresu · Accepted Answer · 2022-11-17 17:33:44Z

1

Within the script block of a Foreach-Object, which is the full name of the command with the alias %, you can in fact use return to skip any statements after the return, and continue on to the next loop.

In your case you simply need to move your return into your else blocks like this:

If (Success Condition){
   Actions to do on success
}
else{
   Actions to do on fail
   return
}

If (Success Condition 2){
   ...
}
else{
   ...
   return 
}

As mentioned in the comments to your question, be sure to read up on how return works in PowerShell as it is somewhat unusual and behaves differently in different contexts.

answered Nov 17, 2022 at 17:33

emanresu

1,0046 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

DrixlRey Over a year ago

Yes, it was this simple! I had the return statement outside, so it never went to the 2nd if statement. Thank you so much! I have marked this as answered from you!

js2010 · Accepted Answer · 2022-11-17 18:01:00Z

0

I would do it this way, just output the objects for either case. Notice the indenting to help see the structure of the code. Return is usually not needed. -ea 0 means "-erroraction silentlycontinue".

Import-Csv TestComputers.csv |
% {
  if (Test-Connection $_.hostname -count 1 -ea 0) {
    [pscustomobject]@{
      Name = $_.hostname
      Status = $true}
  }
  else {
    [pscustomobject]@{
      Name = $_.hostname
      Status = $false}
  }
}


Name          Status
----          ------
yahoo.com       True
microsoft.com  False

answered Nov 17, 2022 at 18:01

js2010

28.3k6 gold badges82 silver badges87 bronze badges

Collectives™ on Stack Overflow

Basic multiple if statement logic flow syntax in PowerShell

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related