return global variable value set inside loop

Question

public class loginbal
{
  public static bool   match = false ;

  public bool check(string username, string password)
  {
        logindal LGD = new logindal();
        DataSet ds1= LGD.logincheck(username, password);

        int noofrows = ds1.Tables["login"].Rows.Count;

        for (int i = 0; i < noofrows; i++)
        {
            if ((ds1.Tables["login"].Rows[i]["username_l"].ToString() == username) && (ds1.Tables["login"].Rows[i]["password_l"].ToString() == password))
            {
                match = true;
            }
        }

    return match;
}

I want to return match but its not affected with for loop set statement what i can do to change match according to for loop value and return to method?

and why do you need a variable in the first place? just return true when you found a match. Also you are never resetting match to false so the method will always return true after you have found a match once. — BrokenGlass
– BrokenGlass, Commented Sep 16, 2011 at 21:33
Get rid of your match variable. Replace match = true with return true, and return match with return false. Presto. — NullUserException
– NullUserException, Commented Sep 16, 2011 at 21:35

Community · Accepted Answer · 2017-05-23 12:19:55Z

2

As @BrokenGlass and @NullUserException have pointed out, there is no need for a variable match, much less a static one. Just return true if the loop finds a match. If it doesn't, return false.

public bool check(string username, string password)
{
    logindal LGD = new logindal();
    DataSet ds1= LGD.logincheck(username, password);

    int noofrows = ds1.Tables["login"].Rows.Count;

    for (int i = 0; i < noofrows; i++)
    {
        if ((ds1.Tables["login"].Rows[i]["username_l"].ToString() == username)
            && (ds1.Tables["login"].Rows[i]["password_l"].ToString() == password))
        {
            return true;
        }
    }

    return false;
}

edited May 23, 2017 at 12:19

CommunityBot

11 silver badge

answered Sep 16, 2011 at 21:38

Paul Bellora

55.4k18 gold badges135 silver badges185 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Ash Burlaczenko Over a year ago

There's no need for .Equals as the .net compiler will do this anyway. Also I rather think returning instead a loop is bad practice as you can't write a flow diagram for the function.

hatchet - done with SOverflow Over a year ago

there is a little difference between Equals and ==. One difference is if the string you call Equals on is null, a null exception will be thrown. Not so for ==.

Paul Bellora Over a year ago

@Ash - Removed the .equals() distinction. My mind was stuck in Java mode, thanks. As for returning in the loop, that can be the OP's call after reading your comment.

Collectives™ on Stack Overflow

return global variable value set inside loop

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related