Javascript if else problem

Question

My if-else is not working, I think that I have a variable issue. When I look at the value of x it is not what is entered in the text field. Any Ideas?

function guess() {

    var x = document.getElementById("magic");

    var word = "please";
    if (x == word) {
        alert("You entered the magic word!");
    } else {
        alert("Please try again!");
    }
}

<form>
    What is the magic word?<br />
    <input type="text" id="magic" onchange="guess()" />
</form>

x = object, you will need to use .value in order to compare with word. — Book Of Zeus
– Book Of Zeus, Commented Sep 18, 2011 at 1:44

broofa · Accepted Answer · 2011-09-18 01:52:00Z

4

You're not getting the value. Use this:

var x =document.getElementById("magic").value;

edited Sep 18, 2011 at 1:52

broofa

38.3k13 gold badges76 silver badges73 bronze badges

answered Sep 18, 2011 at 1:45

Deep Frozen

2,0752 gold badges26 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jared Farrish · Accepted Answer · 2011-09-18 01:49:30Z

4

You want:

var x = document.getElementById("magic").value;

Also, onchange won't work, you'll need to use onkeyup, although onblur is probably more sane:

What is the magic word?<br />
<input type="text" id="magic" onblur="guess()" />

function guess() {
    var x = document.getElementById("magic").value;

    var word = "please";

    if (x == word) {
        alert("You entered the magic word!");
    } else {
        alert("Please try again!");
    }
}

http://jsfiddle.net/6uAhq/

edited Sep 18, 2011 at 1:49

answered Sep 18, 2011 at 1:44

Jared Farrish

49.4k17 gold badges100 silver badges108 bronze badges

2 Comments

icktoofay Over a year ago

Are you sure you'd want it to barrage the user with alerts? (onkey* would alert "Please try again!" for every letter they typed until they typed it all in correctly)

Jared Farrish Over a year ago

Yeah, onblur is probably better. I was thinking of the onchange, not the application.

Michael Irwin · Accepted Answer · 2011-09-18 01:44:51Z

2

You need to check against the actual value of the "magic" element, e.g.:

var x = document.getElementById("magic").value;

I'm assuming "magic" is an input.

answered Sep 18, 2011 at 1:44

Michael Irwin

3,1495 gold badges26 silver badges43 bronze badges

Collectives™ on Stack Overflow

Javascript if else problem

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related