"FATAL ERROR: SIGABRT" when defining a string constructor in a custom String class

Question

This error occurred

FATAL ERROR: test case CRASHED: SIGABRT - Abort (abnormal termination) signal
::error::Error: Exit with code: 134 and signal: null

when I was testing a string constructor "String::String(const char* other)"

String::String(const char* other) // the constructor I'm talking about
    {
         if (other == nullptr)
         {
              String();
         }
         else if (other != nullptr)
         {
              int count{0};
              for (int i = 0; other[i] != '\0'; ++i)
              {
                  count = count + 1;
              }
              slength = count;
              // delete [] ifmt; // ?
              ifmt = new char [slength + 1];
              for (int i = 0; i < slength; ++i)    
              {
                  ifmt[i] = other[i];
              }
              ifmt[slength] = '\0'; 
         }
    }
    }
String::String()
    {
        slength = 0; 
        ifmt = new char[slength + 1]; 
        ifmt[0] = '\0';
    }

in my custom String class.

private:
            
        int slength;
        char* ifmt;

One of the suggestions I received was to create a new option branch to handle "negative length" and construct an empty string in this case, but I have no idea what "negative length" is.

I have also searched for some case on the Internet but I found I have done the things they suggested but it still doesn't work. https://www.geeksforgeeks.org/how-to-create-a-custom-string-class-in-c-with-basic-functionalities/ design a string class constructor c++ custom string exercise in c++

I will be thankful if anyone could give some guidance in this case.

if (other == nullptr) { String(); } does not do what you think it does. — Yksisarvinen
– Yksisarvinen, Commented Feb 5, 2023 at 20:06
@Yksisarvinen could you please clarify this? what does it actually do? — Rurutiaza K
– Rurutiaza K, Commented Feb 5, 2023 at 20:12
If you really want our help then please edit your question to show us a minimal reproducible example. What are you really doing? What is the argument you pass to the constructor? How are you defining your String object? — Some programmer dude
– Some programmer dude, Commented Feb 5, 2023 at 20:13
And I really recommend you invest in some good C++ books to learn from instead. — Some programmer dude
– Some programmer dude, Commented Feb 5, 2023 at 20:14
Note that if (other == nullptr) ... else if (other != nullptr) ... doesn't need the second if; it can be written if (other == nullptr) ... else ... . — Pete Becker
– Pete Becker, Commented Feb 5, 2023 at 20:16

Vlad from Moscow · Accepted Answer · 2023-02-05 20:20:20Z

0

This code snippet

     if (other == nullptr)
     {
          String();
     }

does not make sense.

In this statement

  String();

there is created a temporary object that at once is destroyed.

As a result when a null pointer is passed then the object of the class has uninitialized data members.

Pay attention to that there is a redundant closing brace

    //...
}
}

String::String()

edited Feb 5, 2023 at 20:20

answered Feb 5, 2023 at 20:14

Vlad from Moscow

313k27 gold badges204 silver badges358 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

"FATAL ERROR: SIGABRT" when defining a string constructor in a custom String class

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related