Implementing URL shortener logic in JavaScript

Question

As a result of finding this interesting question, I decided to write an example in JavaScript which implemented the logic and contribute it back to the question. The problem is that I'm having some issues implementing the logic. I can speak Ruby which is what I'm basing my implementation on, but I'm having an issue with an endless while loop which I'm having trouble sorting out.

I have the whole implementation up on js.do.it here: http://jsdo.it/rfkrocktk/k9Jq

function encode(i) {
   if (i == 0) return DICTIONARY[0];

   var result = '';
   var base = DICTIONARY.length;

   while (i > 0) {
       result += DICTIONARY[i % base];
       i = i / base;
   }

   result = result.reverse();
   return result;
}

What am I doing wrong here?

/ probably isn't doing what you expect. 1/2 => 0.5

numbers1311407
– numbers1311407

2011-09-25 21:49:50 +00:00
Commented Sep 25, 2011 at 21:49 — numbers1311407
– numbers1311407, Commented Sep 25, 2011 at 21:49

Kevin Stricker · Accepted Answer · 2011-09-25 21:51:22Z

1

Javascript uses floating point math by default. Use i = Math.floor(i / base);

answered Sep 25, 2011 at 21:51

Kevin Stricker

17.4k5 gold badges49 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Naftuli Kay Over a year ago

That was definitely one of the issues, fixed it.

Collectives™ on Stack Overflow

Implementing URL shortener logic in JavaScript

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related