Remove the last Comma from a string (PHP / Wordpress)

Question

I am generating a list of the terms on a custom post type in Wordpress, in this code i add a comma to the end of each item to separate it in a list format, how would i either eliminate the last the comma from propagating on addition or remove the last comma on the list.

$terms = get_the_terms( $post->ID, 'clients' );
if ( $terms && ! is_wp_error( $terms ) ) :
$clients_list = array();
foreach ( $terms as $term ) {
    $clients_list[] = $term->name;
}
$clients = join( ", ", $clients_list );
$catTags .= "$clients, ";
endif;

I have tried the following to no success;

<em><?php $string = $catTags;
    echo preg_replace("/\,$/","",$catTags); ?></em>

possible duplicate of Removing last comma in PHP?

Wooble
– Wooble

2012-05-02 18:09:10 +00:00
Commented May 2, 2012 at 18:09 — Wooble
– Wooble, Commented May 2, 2012 at 18:09

Sagi · Accepted Answer · 2011-09-30 08:56:21Z

5

You can do simply:

rtrim($catTags, ', ');

answered Sep 30, 2011 at 8:56

Sagi

8,0113 gold badges28 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Sagi Over a year ago

You do need ', ' instead of ',' because you have an extra space at the end of the string. I've just corrected it.

Xavier Over a year ago

thanks, wordpress was generating a space after the , that worked fine thanks ! :D

Xavier Over a year ago

i just realised that and deleted my previous comment haha :D

Rene Pot · Accepted Answer · 2011-09-30 08:58:13Z

0

What I usually do, is to add a comma at the begin of a loop, by checking if there is already data in the variable.

So in this case something like this:

if (strlen($catTags) > 0)
    $catTags .= ',';

answered Sep 30, 2011 at 8:58

Rene Pot

24.8k7 gold badges70 silver badges92 bronze badges

1 Comment

Sagi Over a year ago

So you are calculating the string's length at each iteration? I think it is better to build it with an array, then just join the items with the separator.

9miles · Accepted Answer · 2011-09-30 09:30:25Z

0

This should work:

return substr($string, 0, -strlen(','));

will remove the last comma at the end of the string.

answered Sep 30, 2011 at 9:30

9miles

3211 gold badge2 silver badges10 bronze badges

Collectives™ on Stack Overflow

Remove the last Comma from a string (PHP / Wordpress)

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related