Different ways to remove Object from array using mongoose

Question

Title. I noticed that there are two (maybe more) ways to remove a specific object from an array in a document. Example schema:

var diveSchema = new Schema({
//irrelevant fields
    divers: [{
        user: { type: Schema.Types.ObjectId, ref: 'User', required: true },
        meetingLocation: { type: String, enum: ['carpool', 'onSite'], required: true },
        dives: Number,
        exercise: { type: Schema.Types.ObjectId, ref: 'Exercise' },
    }]
});

For example, here they used $pull syntax

Dive.update({ _id: diveId }, { "$pull": { "divers": { "user": userIdToRemove } }}, { safe: true, multi:true }, function(err, obj) {
    //do something smart
});

to remove a matching object. But sometimes, this is used

let dive = await Dive.findById(diveId)
dive.drivers = dive.drivers.filter(driver => driver.user.toString() !=== userIdToRemove);
await dive.save();

Which one is better and recommended?

SuleymanSah · Accepted Answer · 2023-05-19 11:32:29Z

1

The first one seems to be better, because there is one db access, the second one has two db access (one for findById and one for save)

answered May 19, 2023 at 11:32

SuleymanSah

18k6 gold badges38 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Different ways to remove Object from array using mongoose

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related