Android ArrayList unpredictable behavior

Question

I am experiencing a strange issue with ArrayList on Android

If I do this

        for(int kk=0;kk<mReadRowIds.size();kk++)
        {
            if(mRealRowId==mReadRowIds.get(kk))
            {
                if(kk<mRowNumTimes.size())
                {
                    mArrayNumberPortions.add(mRowNumTimes.get(kk));
                    bFoundIt=true;
                    break;
                }
                else
                {
                    break;
                }
            }
        }

The item is not found, but if I do this

        int readrowidforcmp;
        for(int kk=0;kk<mReadRowIds.size();kk++)
        {
            readrowidforcmp = mReadRowIds.get(kk);
            if(mRealRowId==readrowidforcmp)
            {
                if(kk<mRowNumTimes.size())
                {
                    mArrayNumberPortions.add(mRowNumTimes.get(kk));
                    bFoundIt=true;
                    break;
                }
                else
                {
                    break;
                }
            }
        }

The item is found , can someone explain what the difference between these is to me as I have not got a clue. NOTE: Array has to be over 200 items for it to go wrong.

What type does your mReadRowIds contain?

dymmeh
– dymmeh

2011-10-06 20:50:55 +00:00
Commented Oct 6, 2011 at 20:50 — dymmeh
– dymmeh, Commented Oct 6, 2011 at 20:50

Mirthquakes · Accepted Answer · 2011-10-06 20:55:17Z

1

It looks like maybe when you call the ArrayList's get(index) method, it's returning a generic object. In the first example, you're comparing an integer to that generic object, but in the second you're casting the generic object to an integer (by assignment) and then comparing them.

answered Oct 6, 2011 at 20:55

Mirthquakes

3431 silver badge10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Romain Guy · Accepted Answer · 2011-10-07 03:18:07Z

1

It looks like a typical auto-boxing issue. In your first solution, you wrote "mRealRowId==mReadRowIds.get(kk)". The value in the ArrayList is returned as an Integer and compared to an int auto-cast to an Integer. By comparing the values with == you are performing an identity comparison. The trick is that there is a cache of Integer values between -128 and 127, which is why your code starts breaking around 200.

A simple solution would be to make sure you use only ints and not Integers like in your second solution.

answered Oct 7, 2011 at 3:18

Romain Guy

98.6k18 gold badges221 silver badges200 bronze badges

1 Comment

Chris Over a year ago

Superb , I never knew that - learn something every day. Thank you !

Collectives™ on Stack Overflow

Android ArrayList unpredictable behavior

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related