Why does my if Else if statement not work in Batch script?

Question

My Script

echo "Enter your choice (1 or 2 or 3) :"
set /p dbchoice=

IF %dbchoice EQU 1 ( 
    set dbtype="oracle"
) ELSE ( 
    IF %dbchoice EQU 2 ( 
        set dbtype="sqlserver" 
    )
) ELSE ( 
    IF %dbchoice EQU 3 ( 
        set dbtype="db2" 
    )
) ELSE (
    echo "Incorrect choice" 
)

I get the following output:

E:\csmilm>set /p dbchoice=
1
ELSE was unexpected at this time.
E:\csmilm>) ELSE (
E:\csmilm>

What is the problem here?

On which line does the error occur?

tenfour
– tenfour

2011-10-10 09:12:18 +00:00
Commented Oct 10, 2011 at 9:12 — tenfour
– tenfour, Commented Oct 10, 2011 at 9:12
@tenfour: Check my partial output/ rather error

user801116
– user801116

2011-10-10 09:13:59 +00:00
Commented Oct 10, 2011 at 9:13 — user801116
– user801116, Commented Oct 10, 2011 at 9:13

Igor Kustov · Accepted Answer · 2016-01-25 15:42:22Z

11

Closing brackets in the wrong place. Try:

IF %dbchoice EQU 1 ( 
    set dbtype="oracle"
) ELSE ( 
    IF %dbchoice EQU 2 ( 
        set dbtype="sqlserver" 
    ) ELSE ( 
        IF %dbchoice EQU 3 ( 
            set dbtype="db2" 
        ) ELSE (
            echo "Incorrect choice" 
        )
    )
)

edited Jan 25, 2016 at 15:42

Igor Kustov

3,3062 gold badges36 silver badges31 bronze badges

answered Oct 10, 2011 at 9:18

ChrisBD

9,2393 gold badges25 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

user801116 Over a year ago

It gives me

E:\csmilm>set /p dbchoice= 1 E:\csmilm>IF dbchoice EQU 1 (set dbtype="oracle" ) ELSE (IF dbchoice EQU 2 (set dbtype="sqlserver" ) ELSE (IF dbchoice EQU 3 (set dbtype="db2" ) ELSE ( echo "Incorrect choice" goto end_java_version ) ) ) "Incorrect choice" E:\csmilm>endlocal

Adrien Plisson Over a year ago

windows batch file does not know anything about integers. try if %dbchoice equ "1"

user801116 Over a year ago

Still does not work I added IF %dbchoice EQU "1" and even IF %dbchoice == "1"

user801116 Over a year ago

@Adrien and ChrisBD: Also 1 more help, what if I want to check if something is >= 5 how can I do that in batch script?

Adrien Plisson Over a year ago

you type help if on a command-line and read the documentation. what you need is to replace EQU by GEQ.

Collectives™ on Stack Overflow

Why does my if Else if statement not work in Batch script?

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related