JAVA - import CSV to ArrayList

Question

I'm trying import CSV file to Arraylist using StringTokenizer:

public class Test
{
  public static void main(String [] args)
  {
    List<ImportedXls> datalist = new ArrayList<ImportedXls>();

    try
    {
      FileReader fr = new FileReader("c:\\temp.csv");
      BufferedReader br = new BufferedReader(fr);
      String stringRead = br.readLine();

      while( stringRead != null )
      {
        StringTokenizer st = new StringTokenizer(stringRead, ",");
        String docNumber = st.nextToken( );
        String note = st.nextToken( );  /** PROBLEM */
        String index = st.nextToken( ); /** PROBLEM */

        ImportedXls temp = new ImportedXls(docNumber, note, index);
        datalist.add(temp);

        // read the next line
        stringRead = br.readLine();
      }
      br.close( );
    }
    catch(IOException ioe){...}

    for (ImportedXls item : datalist) {
      System.out.println(item.getDocNumber());
    }
  }
}

I don't understand how the nextToken works, because if I keep the initialize three variables (docNumber, note and index) as nextToken(), it fails on:

Exception in thread "main" java.util.NoSuchElementException
    at java.util.StringTokenizer.nextToken(Unknown Source)
    at _test.Test.main(Test.java:32)

If I keep docNumber only, it works. Could you help me?

The opencsv library makes reading csv files very easy, no need to code your own. — Pete855217
– Pete855217, Commented May 19, 2013 at 10:31

aav · Accepted Answer · 2011-10-10 12:15:46Z

18

It seems that some of the rows of your input file have less then 3 comma separated fields.You should always check if tokenizer has more tokens (StringTokenizer.hasMoreTokens), unless you are are 100% sure your input is correct.

CORRECT parsing of CSV files is not so trivial task. Why not to use a library that can do it very well - http://opencsv.sourceforge.net/ ?

answered Oct 10, 2011 at 12:15

aav

2,4891 gold badge20 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

gaffcz Over a year ago

You're aslo right, problem is in CSV file! Thank you for openCsv, i'll try it too :-)

aav Over a year ago

go for opencsv. just imagine, what will happen with the code, you are about to use, if 'note' field will contain comma. Another question @stackoverflow? :)

gaffcz Over a year ago

Your advice is finally the most convenient, thank you very much! (and don't worry, the next questions are coming soon :D

John B · Accepted Answer · 2011-10-10 12:16:09Z

2

Seems like your code is getting to a line that the Tokenizer is only breaking up into 1 part instead of 3. Is it possible to have lines with missing data? If so, you need to handle this.

answered Oct 10, 2011 at 12:16

John B

33.1k8 gold badges80 silver badges100 bronze badges

Comments

Thomas · Accepted Answer · 2011-10-10 12:16:33Z

2

Most probably your input file doesn't contain another element delimited by , in at least one line. Please show us your input - if possible the line that fails.

However, you don't need to use StringTokenizer. Using String#split() might be easier:

...
while( stringRead != null )
{
    String[] elements = stringRead.split(",");

    if(elements.length < 3) {
      throw new RuntimeException("line too short"); //handle missing entries
    }

    String docNumber = elements[0];
    String note = elements[1];
    String index = elements[2];

    ImportedXls temp = new ImportedXls(docNumber, note, index);
    datalist.add(temp);

    // read the next line
    stringRead = br.readLine();
}
...

answered Oct 10, 2011 at 12:16

Thomas

88.9k13 gold badges126 silver badges162 bronze badges

1 Comment

gaffcz Over a year ago

Thank you, that's it! The CSV file is hasn't three columns everywhere.. Now I'm trying to use your code :-)

cdegu · Accepted Answer · 2011-10-10 12:19:45Z

2

You should be able to check your tokens using the hasMoreTokens() method. If this returns false, then it's possible that the line you've read does not contain anything (i.e., an empty string).

It would be better though to use the String.split() method--if I'm not mistaken, there were plans to deprecate the StringTokenizer class.

answered Oct 10, 2011 at 12:19

cdegu

1531 silver badge9 bronze badges

Collectives™ on Stack Overflow

JAVA - import CSV to ArrayList

4 Answers 4

3 Comments

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related