php preg_replace not doing anything

Question

For some reason my preg_replace call is not working, I have check everything I can think of to no avail. Any suggestions?

foreach ($this->vars as $key=>$var)
{
    preg_replace("/\{$key\}/", $var, $this->tempContentXML);
}

vars is an array containing the $key->value that needs to be replaced in the string, tempContentXML is a string containing XML data.

Piece of the string

...<table:table-cell table:style-name="Table3.B1" office:value-type="string"><text:p text:style-name="P9">{Reference}</text:p></table:table-cell></table:table-row><table:table-row table:style-name="Table3.1"><...

EX.

$this->vars['Reference'] = Test;
foreach ($this->vars as $key=>$var)
{
    preg_replace("/\{$key\}/", $var, $this->tempContentXML);
}

That should replace the string {Reference} with the value in the array at $key

But it is not working.

That loop is very inefficient. Utilze preg_replace_callback and an array lookup. — mario
– mario, Commented Oct 11, 2011 at 6:48

ThiefMaster · Accepted Answer · 2011-10-11 07:13:31Z

3

The replacement does not happen in-place (the new string returned).

foreach ($this->vars as $key=>$var) {
    $this->tempContentXML = preg_replace("/\{$key\}/", $var, $this->tempContentXML);
}

Besides that, don't use a regex for plain string replacements ever (assuming $this->vars does not contain regexes):

foreach ($this->vars as $key=>$var) {
    $this->tempContentXML = str_replace('{'.$key.'}', $var, $this->tempContentXML);
}

edited Oct 11, 2011 at 7:13

answered Oct 11, 2011 at 6:36

ThiefMaster

320k85 gold badges608 silver badges648 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

alex Over a year ago

Will you need to escape the second example's { and } because they are surrounding an interpolated variable?

ThiefMaster Over a year ago

Ty, fixed. Not using embedded vars is nicer anyway.

Collectives™ on Stack Overflow

php preg_replace not doing anything

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related