NullPointerException in Java code

Question

I'm learning Java and OOPS from oracle's website. I'm doing this exercise.

I'm getting a null pointer exception when I run this code. Can someone explain to me what I've done wrong?

Card.java

public class Card {
 public enum Suits {
    SPADE,
    CLUB,
    DIAMOND,
    HEART       
  }

 public enum Ranks {
    Ace,
    DEUCE,
    THREE,
    FOUR,
    FIVE,
    SIX,
    SEVEN,
    EIGHT,
    NINE,
    TEN,
    JACK,
    QUEEN,
    KING    
  }

    public Ranks rank;
    public Suits suit;

    public Card(Card.Ranks rank,Card.Suits suit) {
        this.rank=rank;
        this.suit=suit;
    }
}

Deck.java

import java.util.*;

public class Deck {
    public ArrayList<Card> cards;
    private Card card;

    public Deck() {
        for(Card.Suits s: Card.Suits.values()) {
            for(Card.Ranks r:Card.Ranks.values()) {
                card=new Card(r,s);
                 cards.add(card);
            }
        }
    }
}

DisplayCards.java

public class DisplayCards {
    public static void main(String [] args) {
        Deck d=new Deck();
        for( Card c: d.cards) {
            System.out.println("Rank of the Card:"+c.rank.toString());
            System.out.println("Suit of the Card:"+c.suit.toString());  
        }
    }
}

Try pasting the stack trace from the exception into the question. This is usually the best way to start diagnosing such a problem. — Bill Michell
– Bill Michell, Commented Oct 13, 2011 at 14:40
It might speed up things if you said exactly were you get this NPE. Removing empty lines wouldn't hurt either. — Ben van Gompel
– Ben van Gompel, Commented Oct 13, 2011 at 14:40
Extremely silly of me to not being able to debug on my own. Thank you everyone for helping out so quick. — gizgok
– gizgok, Commented Oct 13, 2011 at 15:18

solendil · Accepted Answer · 2011-10-13 14:40:14Z

8

public ArrayList<Card> cards; is never initialized, use public ArrayList<Card> cards = new ArrayList<Card>();

answered Oct 13, 2011 at 14:40

solendil

8,4684 gold badges30 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

amit · Accepted Answer · 2011-10-13 14:40:45Z

4

you did not create the new ArrayList for cards.

replace: public ArrayList<Card> cards; with public ArrayList<Card> cards = new ArrayList<Card>();

answered Oct 13, 2011 at 14:40

amit

179k27 gold badges245 silver badges348 bronze badges

Comments

javanna · Accepted Answer · 2012-01-21 21:07:25Z

4

You need to initialize the list as well:

cards = new ArrayList<Card>();

edited Jan 21, 2012 at 21:07

javanna

60.4k14 gold badges147 silver badges125 bronze badges

answered Oct 13, 2011 at 14:41

Rob

4,94712 gold badges53 silver badges57 bronze badges

Comments

Jetti · Accepted Answer · 2011-10-13 14:41:19Z

2

Now I'm coming from more of a C# background, but it doesn't look like you initialized your ArrayList Cards. Try initializing it in the constructor with:

cards = new ArrayList<Card>();

and that should fix your problem.

answered Oct 13, 2011 at 14:41

Jetti

2,4681 gold badge17 silver badges25 bronze badges

Collectives™ on Stack Overflow

NullPointerException in Java code

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related